feat: promote the liquidity hub in the top bar and landing page - #5797
Open
cuzz-venus wants to merge 2 commits into
Open
feat: promote the liquidity hub in the top bar and landing page#5797cuzz-venus wants to merge 2 commits into
cuzz-venus wants to merge 2 commits into
Conversation
Move the dashboard entry to the right of the top bar, ahead of the reward claim button, rename the markets menu to Borrow, and point the landing page call to action at the liquidity hub where it is available.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Greptile SummaryThe PR promotes Liquidity Hub through the landing-page CTA, moves Dashboard into the top-bar action group, and renames Markets to Borrow.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/evm/src/pages/Landing/Hero/index.tsx | Selects the Liquidity Hub CTA route and label when enabled while preserving the chain-aware markets fallback. |
| apps/evm/src/containers/Layout/NavBar/index.tsx | Moves the desktop Dashboard link into the action group while retaining it in mobile navigation. |
| apps/evm/src/containers/Layout/NavBar/useMenuItems/index.tsx | Extracts the Dashboard menu item and renames the Markets navigation group to Borrow. |
| apps/evm/src/libs/translations/translations/ja.json | Replaces the previously reported placeholders with Japanese translations for the CTA and Borrow label. |
| apps/evm/src/libs/translations/translations/th.json | Replaces the previously reported placeholders with Thai translations for the CTA and Borrow label. |
| apps/evm/src/libs/translations/translations/tr.json | Replaces the previously reported placeholders with Turkish translations for the CTA and Borrow label. |
| apps/evm/src/libs/translations/translations/vi.json | Replaces the previously reported placeholders with Vietnamese translations for the CTA and Borrow label. |
| apps/evm/src/libs/translations/translations/zh-Hans.json | Replaces the previously reported placeholders with Simplified Chinese translations for the CTA and Borrow label. |
| apps/evm/src/libs/translations/translations/zh-Hant.json | Replaces the previously reported placeholders with Traditional Chinese translations for the CTA and Borrow label. |
Reviews (2): Last reviewed commit: "feat: add translation" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
@greptile review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-1912
Changes
Dashboardentry from the left of the top bar to the right, just ahead of the reward claim button, and renamed theMarketsmenu toBorrow.