Skip to content

test(deploy_keys): drop the cases the contract tests and scenarios already pin #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vivswan merged 1 commit into from
Sep 22, 2026
Merged

test(deploy_keys): drop the cases the contract tests and scenarios already pin #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 13 additions & 52 deletions src/sections/deploy_keys/deploy_keys.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,33 +218,19 @@ describe("deploy_keys schema", () => {
});

describe("deploy_keys validation before any read", () => {
test.each<
[label: string, declared: Parameters<typeof deployKeysSection.validate>[0], issue: RegExp]
>([
[
"duplicate declared titles",
[
{ title: "deploy-bot", key: BOT_KEY },
{ title: "deploy-bot", key: MIRROR_KEY },
],
/^\[1\]\.title: "deploy-bot" names the same deploy key as "deploy-bot" declared earlier/,
],
[
"duplicate declared MATERIAL under different titles (comments ignored)",
[
{ title: "deploy-bot", key: `${BOT_KEY} deploy@bot` },
{ title: "mirror-pull", key: `${BOT_KEY} mirror@other-comment` },
],
/^\[1\]\.key: the entries "deploy-bot" and "mirror-pull" declare the same key material.*keep one entry per key$/s,
],
])(
"%s is one validate issue at the offending field, so the document fails before any API call",
(_label, declared, issue) => {
expect(
deployKeysSection.validate(declared).map((found) => `${found.path}: ${found.message}`),
).toEqual([expect.stringMatching(issue)]);
},
);
test("duplicate declared MATERIAL under different titles (comments ignored) is one validate issue at the offending field, so the document fails before any API call", () => {
const declared = [
{ title: "deploy-bot", key: `${BOT_KEY} deploy@bot` },
{ title: "mirror-pull", key: `${BOT_KEY} mirror@other-comment` },
];
expect(
deployKeysSection.validate(declared).map((found) => `${found.path}: ${found.message}`),
).toEqual([
expect.stringMatching(
/^\[1\]\.key: the entries "deploy-bot" and "mirror-pull" declare the same key material.*keep one entry per key$/s,
),
]);
});
});

describe("deploy_keys conflicts", () => {
Expand All @@ -271,20 +257,6 @@ describe("deploy_keys conflicts", () => {
},
);

test("two live keys under one title fail loudly, declared or not: GitHub does not enforce title uniqueness", async () => {
const api = new MockApi({
[LIST]: {
data: [liveKey(11, "deploy-bot", BOT_KEY), liveKey(12, "deploy-bot", MIRROR_KEY)],
},
});
await expect(plan(api, [{ title: "deploy-bot", key: BOT_KEY }])).rejects.toThrow(
'deploy_keys: GitHub holds deploy keys that resolve to one identity: "deploy-bot (key id 11)" and "deploy-bot (key id 12)". ' +
"This section manages one deploy key per identity, so it cannot tell them apart; delete all but one of each on GitHub, then run again",
);
await expect(plan(api, [])).rejects.toThrow(/resolve to one identity/);
expect(api.mutations()).toEqual([]);
});

test("the guard runs before the section's live conflicts: a duplicated title wins over a colliding holder's material", async () => {
const api = new MockApi({
[LIST]: { data: [liveKey(7, "dup", BOT_KEY), liveKey(8, "dup", MIRROR_KEY)] },
Expand Down Expand Up @@ -591,15 +563,4 @@ describe("deploy_keys convergence", () => {
expect(await post({ title: "other-title", key: `${BOT_KEY} some@comment` })).toBe(422);
expect(api.state.deploy_keys.map((k) => k.title)).toEqual(["deploy-bot", "deploy-bot"]);
});

test("the read port exposes exactly the list role in its denied posture", () => {
const ctx = planContext(deployKeysSection, new MockApi({}), REPO);
expect(Object.keys(ctx.read)).toEqual(["list"]);
// @ts-expect-error a write role is not a read: the port has no `create`
ctx.read.create;
// @ts-expect-error nor a `remove`
ctx.read.remove;
// @ts-expect-error a "denied" primary read offers no 404-tolerant helper
ctx.read.list.probeAbsent;
});
});
Loading