Skip to content

test(secret_scanning_custom_patterns): drop the read-port case the contract tests already pin #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vivswan merged 1 commit into from
Sep 22, 2026
Merged

test(secret_scanning_custom_patterns): drop the read-port case the contract tests already pin #398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/sections/secret_scanning_custom_patterns/secret_scanning_custom_patterns.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,19 +344,6 @@ describe("secret_scanning_custom_patterns", () => {
["vendor-key", "key-[0-9]{6}", undefined],
]);
});

test("the read port exposes exactly the list role in its denied posture", () => {
const ctx = planContext(secretScanningPatternsSection, new MockApi({}), REPO);
expect(Object.keys(ctx.read)).toEqual(["list"]);
// @ts-expect-error a write role is not a read: the port has no `create`
ctx.read.create;
// @ts-expect-error nor an `update`
ctx.read.update;
// @ts-expect-error nor a `remove`
ctx.read.remove;
// @ts-expect-error a "denied" primary read offers no 404-tolerant helper
ctx.read.list.probeAbsent;
});
});

describe("secret_scanning_custom_patterns snapshot", () => {
Expand Down
Loading