Skip to content

test(webhooks): move the events test into its section directory - #413

Merged
Vivswan merged 1 commit into
mainfrom
wt/hotfix-webhooks-events-test
Sep 22, 2026
Merged

Vivswan merged 1 commit into
mainfrom
wt/hotfix-webhooks-events-test

Conversation

@Vivswan

@Vivswan Vivswan commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Before / After

Before: test/sections/webhooks-events.test.ts sits flat beside the cross-section suites; changed-sections refuses a section-named flat file there, so checks / check on main fails on one test.

After: test/sections/webhooks/events.test.ts, inside its section directory, where the mirror rule puts it.

How

  • git mv of one file; its one relative import gains one ../.

Proof

  • bun test test/sections/webhooks/events.test.ts test/scripts/changed-sections.test.ts: 45 pass, 0 fail (the selector's file-map case is the one that was red on main).
  • typecheck, lint green. CI is the full proof.

Line accounting

  • 1 file renamed, 1 import line changed.

Reviewer note

  • Two changes landed within minutes of each other: the mirror move and the events test; each was green against the main it was built on, and only their combination fails. The layout census in the e2e-always change would have caught this on the PR.

BEGIN_COMMIT_OVERRIDE
test(webhooks): move the events test into its section directory

The webhook events test was added flat beside the cross-section suites in the same hour the section mirror moved into test/sections/.
The section selector refuses a section-named file there, so main's check job is red.
The file moves to test/sections/webhooks/events.test.ts with its imports one level deeper.
END_COMMIT_OVERRIDE

The webhook events test was added flat beside the cross-section suites in the same hour the section mirror moved into test/sections/.
The section selector refuses a section-named file there, so main's check job is red.
The file moves to test/sections/webhooks/events.test.ts with its imports one level deeper.
@Vivswan Vivswan added the merge-when-green Owner approved: merge once every gate is green label Sep 22, 2026
Copilot AI balanced review requested due to automatic review settings September 22, 2026 09:32
@github-actions

Copy link
Copy Markdown
Contributor

File size check

0 over a hard cap (fails), 30 warning(s).

File Size Tier Cap
.github/scripts/release-pipeline.ts:6 156 chars warn 150
.github/scripts/release-pipeline.ts:453 151 chars warn 150
.github/scripts/release-pipeline.ts:1247 153 chars warn 150
.github/scripts/release-pipeline.ts:1 34 comment lines (header) warn 25
.github/scripts/release-pipeline.ts:449 14 comment lines warn 10
.github/workflows/post-green.yml:29 153 chars warn 150
.github/workflows/update-release-pr.yml:109 14 comment lines warn 10
docs/upgrading/v2-to-v3.md 1276 lines warn 1040
src/engine/layers.ts:217 157 chars warn 150
src/flows/settings-write.ts:142 159 chars warn 150
src/flows/settings-write.ts:30 11 comment lines warn 10
src/flows/snapshot.ts:189 13 comment lines warn 10
src/github/secret-scan.ts:42 11 comment lines warn 10
src/schema.ts:186 153 chars warn 150
src/schema.ts:197 176 chars warn 150
src/sections/contract/errors.ts:14 14 comment lines warn 10
src/sections/contract/module.ts:963 185 chars warn 150
src/sections/contract/module.ts:627 12 comment lines warn 10
src/sections/contract/module.ts:897 12 comment lines warn 10
src/sections/secret_scanning_custom_patterns/compilable-form.ts:382 161 chars warn 150
src/sections/shared/roles.ts:43 13 comment lines warn 10
src/types.ts:16 156 chars warn 150
test/docs/guides.test.ts:451 155 chars warn 150
test/e2e/generators.ts 2633 lines warn 2560
test/e2e/generators.ts:1703 166 chars warn 150
test/e2e/generators.ts:1857 161 chars warn 150
test/e2e/generators.ts:1666 12 comment lines warn 10
test/engine/execute.test.ts:617 152 chars warn 150
test/flows/merge-parity.test.ts:63 164 chars warn 150
test/scripts/auto-fix-allowlist.test.ts:8 12 comment lines warn 10

Split the file, wrap the line, shorten or exempt the comment, or list the path in .file-size-allow.local with a # reason.

5 managed file(s) skipped; repo-platform owns them.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The relocated test uses the correct relative import and matches the section layout convention.

Review effort: Balanced
Findings: None

What changed in this PR

Moves the webhook events test into its mirrored section directory so section-based test selection works correctly.

Changes:

  • Relocates the webhook events test under test/sections/webhooks/.
  • Updates its source import for the additional directory depth.
File Description
test/​sections/​webhooks/​events.test.ts Updates the webhook events import path after relocation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Vivswan
Vivswan merged commit 46ef064 into main Sep 22, 2026
32 checks passed
@Vivswan
Vivswan deleted the wt/hotfix-webhooks-events-test branch September 22, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-green Owner approved: merge once every gate is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants