Repository navigation
docs(upgrading): count every public-entry break among the library sections - #480
Merged
Merged
Conversation
Contributor
File size check0 over a hard cap (fails), 1 warning(s).
Split the file, wrap the line, shorten or exempt the comment, or list the path in 5 managed file(s) skipped; repo-platform owns them. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Section 51 remains a public break through the exported SettingsFile and SectionInput shapes, making the new count inaccurate.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates the v2-to-v3 guide’s accounting of library-consumer breaks.
Changes:
- Expands the library-impact section list.
- Removes the section 51 library note.
| File | Description |
|---|---|
docs/upgrading/v2-to-v3.md |
Updates the library-break count and section list. |
docs/upgrading/v2-to-v3/refusals-lists.md |
Removes the section 51 library-impact statement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vivswan
force-pushed
the
docs/upgrading-facts
branch
from
October 6, 2026 06:17
7cb4ea6 to
90000b9
Compare
…le and SectionInput Section 51 and nine other parse-time refusals narrowed a nested type under the exported SettingsFile and SectionInput, so a literal that compiled under the pre-release public entry fails now. Each of the ten states the break through the exported type, and the intro counts twenty-six library sections. The eight refusals that are refinements alone (36, 42, 43, 44, 46, 48, 50, 52) change no type and stay out of the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before
After
How
parseConfig(library.md line 203) takesRunCapabilitiesas a third argument.SectionModule.snapshot()(line 294) is required once an endpoint declares a read.SnapshotReport.yaml(line 185) reorders and drops its dated line.Layering(line 74) loses"merge".runRender,RenderConfig,FinishedRender,concludeRender(lines 213 to 220) replace the merge names.SettingsFile(line 107) andSectionInput(line 298), so a literal that compiled against the pre-release entry fails now.Proof
bun test test/docs/guides.test.ts test/docs/readme.test.ts, 265 pass.docs-probe.mtsover the nine pages, clean; a tsc probe fails each of the ten narrowings at head and compiles the same literal against the pre-release entry.Technical details
v2-to-v3.md10,run.md16,layering.md7,refusals-lists.md14,refusals-repository.md7); the other four area pages have no diff.git diff --numstat origin/main...HEAD):v2-to-v3.md1 added, 1 removed;run.md4 added;layering.md2 added;refusals-lists.md9 added, 1 removed;refusals-repository.md10 added.SettingsFileat aa43d3e^ and at head; one@ts-expect-errorliteral per claimed break fails at head and compiles against the pre-release entry; a control with one marker removed reports that line.string), 42 collaborators and teams (permission and slug checks onstring), 43 secret and variable names (regex and byte cap onstring), 44 check-suiteapp_id(positivity and uniqueness onnumber), 46 deploy keys (key format onstring), 48 secret scanning patterns (regex compile onstring), 52 autolinks (charset, placeholder, and prefix checks onstring).due_on, sodue_on: nullnever compiled and the day form compiles now.repositoryandbranches[].protectionkeep an index signature, sohas_downloads: falseor a protectionurlcompiles and is refused at parse; the sentences in 37 and 41 name only the enum and shape narrowings.enforcementandactor_typeare stated.include_claim_keysdiscriminant is in the table row above it.parseConfig(read, env)toparseConfig(read, env, { artifactUpload })row, so section 22's sentence links nothing new there.parseConfig(read, env)had two arguments before refactor(flows)!: one owner per refusal, read, and write; one wording for both faces #208;snapshot?was optional onSectionModulebefore cb772c5;Layeringwas"merge" | "replace"before 8133147;DeploymentBranchPolicyConfig.typewasz.string()before feat(environments)!: declared-off protection converges, and the schema refuses what GitHub never accepts #266.docs/upgrading/{v2-to-v3.md,v2-to-v3/run.md,v2-to-v3/layering.md,v2-to-v3/refusals-repository.md,v2-to-v3/refusals-lists.md}.