Repository navigation
fix(transcript): a transcript clock that leaves the screen names its zone (#447) - #462
Merged
Merged
Conversation
model=koishi/qwen3.8-flash-next-mtp gate='python3 -m pytest tests --ignore=tests/e2e && ruff check tapscribe tests && ruff format --check tapscribe tests && node --test "tapscribe/web/js/**/*.test.js" && node tapscribe/web/tools/check-conventions.mjs && node tapscribe/web/tools/check-slots.mjs && node tapscribe/web/tools/check-css-vars.mjs && ( cd frontend && npm run typecheck )'
…zone (#447) The server rendered the merged transcript clock in UTC and the browser in the viewer's zone, so the summary and session-transcript.txt disagreed with the pane and the .txt download by the viewer's offset. Text artefacts (session-transcript.txt, the summarizer input, the clipboard copy and the .txt download) now carry HH:MM:SS±HH:MM. The on-screen panes keep a bare HH:MM:SS in the viewer's zone. ADR-0026 records the rule. Closes #447
Vortiago
added a commit
that referenced
this pull request
Oct 3, 2026
PyAV 19.0.0 removes the `metadata_errors` argument that faster-whisper 1.2.1 passes to `av.open()`. Every transcribe then fails with `TypeError: open() got an unexpected keyword argument 'metadata_errors'`. CI shows it: both bridge E2E jobs on #462 fail in the transcribe stage with av 19.0.0, and the last green `main` run installed av 18.1.0. This PR adds `av<19` to the `whisper-cpu` extra. Remove the cap when a faster-whisper release supports PyAV 19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged transcript clock rendered in UTC on the server and in the viewer's zone in the browser. At UTC+2 the pane and the
.txtdownload read14:05:12, whilesession-transcript.txtand the summary read12:05:12.This change applies the rule in ADR-0026: a transcript line that leaves the screen names its zone.
session_merge._clockrendersHH:MM:SS±HH:MMand keeps the instant's own offset.text.parse_isokeeps an explicit offset and reads a naive stamp as UTC.formatters.fmtClockZrenders the same zoned clock in the browser under a pinneden-USlocale, so the bytes are stable in every viewer locale.buildCopyTextuses it, so the clipboard copy and the.txtdownload carry the zone.HH:MM:SSin the viewer's zone.CONTEXT.mddefines "Zoned clock". Tests cover both renderers and the summarizer input.Gate: pytest (without e2e), ruff check, ruff format, node tests, the three web checks and the frontend typecheck all pass.
Closes #447