Skip to content

fix(GitHub Actions): Workflows fail on forked branches - #2334

Merged
hirokiterashima merged 9 commits into
developfrom
actions-fails-on-fork
Aug 26, 2026
Merged

fix(GitHub Actions): Workflows fail on forked branches#2334
hirokiterashima merged 9 commits into
developfrom
actions-fails-on-fork

Conversation

@Aaron-Detre

Copy link
Copy Markdown
Contributor

Changes

  • generate-messages.yml now checks whether the pull request is from a fork or from the main project.
  • If the PR is on the main project, it acts the same as before:
    • If there are no i18n changes required, the workflow succeeds.
    • If there are i18n changes required, it runs extract-i18n and commits the changes.
  • If the PR is on a fork:
    • If there are no i18n changes required, the workflow succeeds.
    • If there are i18n changes required, the workflow fails with a message telling the author to run extract-i18n locally and commit the changes.
  • I also fixed various errors that were present in generate-messages.yml and other-branch-workflows.yml

Test

  • Testing GitHub Actions Changes From Fork
    • "test commit 2 (no i18n changes)" (which turned out to require i18n changes because I never undid the change from the original commit) failed with the error message.
    • "updated messages" succeeded because I ran extract-i18n locally and there were no more i18n changes required.
  • Testing GitHub Actions Changes From Main Project
    • "test commit 2 (no i18n changes)" succeeded because there were no i18n changes required.
    • "test commit 3 (i18n changes required)" succeeded and automatically updated the messages.xlf

@Aaron-Detre Aaron-Detre self-assigned this Aug 9, 2026
@Aaron-Detre Aaron-Detre added the bug Something isn't working label Aug 9, 2026
@qltysh

qltysh Bot commented Aug 9, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Aaron-Detre
Aaron-Detre marked this pull request as ready for review August 9, 2026 21:56

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima
hirokiterashima merged commit 1d4f508 into develop Aug 26, 2026
4 checks passed
@hirokiterashima
hirokiterashima deleted the actions-fails-on-fork branch August 26, 2026 19:27
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.236.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants