chore(ci): bump create-github-app-token to @v3 (Node 24) - #25
Merged
Conversation
create-github-app-token@v1 is the last Node 20 pin in this repo, and 16 repos call this reusable at @v14, so it is the single highest-leverage line in the sweep. v1->v3 keeps all three outputs and every input we pass; the only removal is v1s deprecated underscore aliases, and this call site already uses app-id/private-key. NOTE: this repo ci gate is actionlint only, so it cannot prove the token step still works. Moving the v14 floating tag is the step that reaches consumers and is deliberately NOT done here. Hardsix/action-wait-for-api@v2.0.2 in deploy-strapi.yml stays: it is Node 20 but v2.0.2 is the latest upstream release, so there is nothing to bump to. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last Node 20 pin in this repo:
actions/create-github-app-token@v1→@v3independabot-auto-merge.yml.This is the highest-leverage single line in the sweep — 16 repos call this reusable at
@v14, so every one of them currently carries the Node 20 deprecation annotation from this one step.Everything else here is already Node 24
I inventoried every
uses:onmain:One exception is not fixable and is left alone:
Hardsix/action-wait-for-api@v2.0.2indeploy-strapi.ymlis Node 20, andv2.0.2is the latest upstream release — there is no version to bump to. That needs its own decision (fork, or replace with a ~10-linecurlpoll).Why
v1→v3is safeI diffed
action.ymlat both refs:token,installation-id,app-slug. This workflow consumessteps.app-token.outputs.token.private-keymoved fromrequired: falsetorequired: true, and we always pass it.app_id,private_key). This call site uses the hyphenated form:Verification is weak here — read before merging
This repo's
cigate is actionlint only. It lints YAML; it does not execute the reusable. A broken token step would lint clean and then silently stop auto-merge across all 16 consumers.So merging this PR is not the risky step — moving the
v14floating tag is, because that is what consumers actually resolve. I have deliberately not moved it. PerRELEASING.mdthat is a separate action, and it should follow one deliberate test of auto-merge on a real Dependabot PR in a single tier-2 repo.For reference,
mainis currently 1 commit ahead ofv14, and that commit touches only.github/dependabot.yml— this repo's own Dependabot config, not any published reusable. So moving the tag would ship this token bump and nothing else functional.Part of the org-wide Node 24 action sweep.