to main - #248
Merged
Merged
Conversation
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 5.0.6 to 5.0.7. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v5.0.6...v5.0.7) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 5.0.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…-expansion-5.0.7 chore(deps): Bump brace-expansion from 5.0.6 to 5.0.7
Preserves working-tree changes that were left uncommitted on `dev` since 2026-07-17 (no branch/issue/PR). Adds a `venueId` ObjectId ref to the gig schema plus a minimal Venue model, and makes gig find/findSort populate the linked venue's name/city/usState/website so the SocketCluster gig feed can carry venue details. Relates to the gig↔venue linkage effort (JaM#1220 render-time venue link, JaM#1242 Gigs Location column). INCOMPLETE for the current design: the venue schema here lacks a street `address` field that JaM#1242 needs. Not reviewed, not tested, no issue yet — parked pending decision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Reformat gig-facade.ts try/catch blocks to multi-line so the populate() calls no longer trip max-len (fixes the RED lint gate). - Add a street `address` field to the Venue schema and include it in the gig find/findSort populate alongside name/city/usState/website, for JaM#1242's Gigs Location column. - Add gig-facade tests covering find/findSort populate behaviour (success returns a populated venue subdocument incl. address; failure propagates the rejection), matching the existing Facade test style.
…ulate Populate linked venue on the gig feed (gig↔venue linkage)
The catch block in AgController.newGig() transmitted socketError then broke out of the receiver loop, permanently killing that client socket's newGig/newTour consumer after the first error. Sibling handlers (editDoc, removeGig) already transmit-and-continue; newGig now matches that behavior. Bump 3.0.8 -> 3.0.10 (skipping 3.0.9, already claimed by PR #245/#244).
…k-loop # Conflicts: # package.json
…or (#246) CircleCI build 474 timed out in test/AgController/index.spec.ts. Root cause: after the earlier fix removed the error-path `break`, `newGig()`'s `if (receiver.done) break;` remained INSIDE the try block, right after the success path — so it was skipped whenever the catch fired. Several existing tests mock the receiver consumer to always resolve `{ ..., done: true }` on a payload that throws (invalid token/gig data); with the check unreachable on that path, those tests' un-awaited background loops spin forever, starving the event loop and hanging the whole suite. Fix: move the done-check to run unconditionally after the try/catch, matching the sibling editDoc/removeGig handlers. Production behavior is now correct too — the loop keeps serving newGig events after an error and still terminates cleanly when the client stream truly ends. Also fixed a latent test-pollution bug this hang had been masking: a test replaces the shared `utils.handleGig`/`utils.removeGig` exports with vi.fn() stubs and never restores them, which silently broke the #246 regression test's assertion that createDocs gets called on the second, valid newGig. Added restoration in afterEach. npm test: 10 test files / 86 tests passed, lint clean, no hang.
newGig receiver loop breaks permanently after one error — later newGig events on that socket are dropped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.