to main - #255
Merged
Merged
Conversation
updateGig caught its own errors and returned the message as a string, so it resolved normally and editDoc's catch (which transmits socketError) never saw the failure. A failed gig update emitted neither socketError nor gigUpdated. Rethrow so editDoc's existing catch is the single place the error is handled and transmitted, matching the pattern already used by handleGig/handleImage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Covers validation-failure, database-failure, and success paths for updateGig directly, plus editDoc-level integration tests asserting socketError transmission (or none, on success) and that editTour behaves identically to editGig. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Failed gig update reports nothing: updateGig swallows its error, so neither socketError nor gigUpdated is emitted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.