Redact support recovery paths by default - #4957
Draft
Widthdom wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status --configby default.--show-pathshandling, structured redaction metadata, and safely quoted recovery commands without rewriting rendered shell text.Root cause
Recovery metadata serialized resolved absolute argv before rendering, while
status --configemitted resolved path settings without the same support-safe policy. File-URI query components also required structural decoding and sanitization before safe reconstruction.Validation
dotnet build CodeIndex.sln --no-restore(0 warnings, 0 errors)make lintdotnet run --project tools/CodeIndex.Changelog -- check(33 fragments validated)Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/4860.security.md.Related: #4955
Fixes #4860