Map internal symbols to correct LSP kinds - #4968
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 29, 2026 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SymbolKindandCompletionItemKind, including module-shaped imports and conservative unknown/plugin fallbacks.constructorfunctions.Root cause and impact
The three LSP surfaces projected broad persisted kinds through incomplete or separate mappings, and some paths did not retain the semantic metadata needed to distinguish constructors and enum members. This caused imports to appear as variables, constructors as functions, and language-specific enum entries to use inconsistent kinds. The shared mapping now keeps all three surfaces aligned.
Validation
dotnet build CodeIndex.sln --no-restore— passed with 0 warnings and 0 errors.LspServerTestsclass — 120/120 passed on both net8.0 and net9.0.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.dotnet run --project tools/CodeIndex.Changelog -- check— validated all 41 fragments.git diff --check— passed.RunCore_SubprojectObservesAncestorIgnoreFileChanges_Issue4592: net9.0 had 10,300 passed / 420 skipped / 1 failed; net8.0 had 10,774 passed / 7 skipped / 1 failed. The Issue Map internal symbols to correct LSP symbol and completion kinds #4870 tests and complete LSP test class pass independently on both targets.Adversarial review
Documentation and changelog
DEVELOPER_GUIDE.md.TESTING_GUIDE.md.changelog.d/unreleased/4870.fixed.md.Follow-ups
None within the requested issue scope.
Fixes #4870