Standardize batch error envelopes - #4969
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 29, 2026 01:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch --json-summarysuccess and failure records on the versioned typed error envelope, including malformed input, schema/policy rejection, unsupported commands, child failures, timeouts, and cancellation.raw_streamsonly through explicit--include-raw-streamsopt-in.Validation
dotnet build CodeIndex.sln -c Debug --no-restore— passed, 0 warnings.dotnet build CodeIndex.sln -c Release --no-restore— passed, 0 warnings.RunBatchtests — net8.0: 35/35 passed; net9.0: 35/35 passed.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.dotnet run --project tools/CodeIndex.Changelog -- check— 41 fragments validated.RunCore_SubprojectObservesAncestorIgnoreFileChanges_Issue4592; its focused retry failed in this worktree, while the isolatedorigin/mainbaseline passed.Adversarial review
Two Codex adversarial-review rounds were completed. The actionable findings were addressed: cancellation now wakes blocked input subscriptions without an orphan per-invocation reader, consumed and concurrently prepared items receive ordered typed records, queued items drain before the final summary, and cancellation takes precedence over earlier failures and blank/oversized branches.
Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/4871.fixed.md.Follow-up candidates
None in scope. The validation-only watcher instability is already tracked by #4592.
Fixes #4871