Normalize C# field initializer symbols - #4970
Merged
Merged
Conversation
Widthdom
marked this pull request as ready for review
July 29, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fieldsymbols while preserving real properties and existing symbol metadata.…markers while retaining modifiers, types, declarators, and comment-safe declaration structure.fieldidentity through persisted receiver resolution, search declaration metadata, reference lookup, and LSP document/completion projections.Root cause
The ordinary-field matcher reused an internal
propertykind, and the previous size bound truncated a flattened initializer prefix. Downstream receiver, search, and LSP paths therefore continued to assume those members were properties even after public normalization.Validation
dotnet build CodeIndex.sln -c Release --no-restore— passed with 0 warnings and 0 errors.dotnet format CodeIndex.sln --no-restore --verify-no-changes— passed.dotnet run --project tools/CodeIndex.Changelog -- check— validated all 36 fragments.git diff --checkandcdidx status --check --json— passed; the local index matches the committed workspace.Documentation and changelog
DEVELOPER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/4865.fixed.md.Follow-up candidates
.gitignorewatcher reconciliation timeout observed during Release validation.Fixes #4865