chore(ci): scope e2e-tests-split.yml's pull_request trigger to relevant paths - #1267
Merged
Conversation
…nt paths The 15-job, 20-30 minute E2E matrix ran on every PR regardless of what changed, including CI-YAML-only changes to unrelated workflow files, doc-only comments, and release-please's version-bump-only PRs (which touch only .release-please-manifest.json) -- none of which can affect E2E test outcomes. Add a paths: filter to the pull_request trigger scoped to what the E2E suite actually builds/tests against: backend/**, frontend/**, tests/**, the Dockerfile and .dockerignore, the E2E compose files, root npm/playwright config, the go.work files, and the E2E workflow file itself. Matches the existing paths-on-pull_request-only convention already used in docker-build.yml and orthrus-build.yml. The push/workflow_run/workflow_dispatch triggers are left unfiltered, same as that existing convention -- this only reduces PR-iteration noise, not post-merge validation coverage.
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-tests-split.yml'spull_request:trigger had no path filter, so the full ~15-job, 20-30 minute E2E matrix ran on every PR regardless of what changed — including PRs that touched only unrelated CI workflow files, docs, or release-please's version-bump-only PRs (which touch exactly one file:.release-please-manifest.json). None of those can affect E2E test outcomes.Fix
Added
paths:to thepull_request:trigger, scoped to what the E2E suite actually builds/tests against:backend/**,frontend/**— built into the Docker image under testtests/**— the Playwright suite itselfDockerfile,.dockerignore— the image build.docker/compose/**— the E2E compose stack (docker-compose.playwright-ci.yml)package.json,package-lock.json,playwright.config.js— root-level npm/Playwright config (confirmed these live at repo root, not undertests/)go.work,go.work.sum— the Go workspace file backend/agent both depend on.github/workflows/e2e-tests-split.yml— the workflow itselfMatches the existing
paths:-on-pull_request-only convention already used in this repo (docker-build.yml,orthrus-build.yml) — thepush/workflow_run/workflow_dispatchtriggers are deliberately left unfiltered, same as that precedent. This only reduces PR-iteration noise; post-merge validation coverage (nightly, weekly promotion) is unaffected.Targets
development(notmain) since this is a quality-of-life CI change, not a hotfix — normal flow, soaks via nightly before the next promotion.Test plan
actionlintcleanlefthook run pre-commitcleane2e-tests-split.ymlbuilds/runs against (grepped forDockerfile/docker-composereferences, checkedDockerfile'sCOPYsources, confirmedpackage.json/playwright.config.jslive at repo root) to make sure the allowlist doesn't miss anything that could silently skip real E2E coverage.release-please-manifest.json, which is correctly excluded