Conversation
Applied @willbooster/wbfy v18.2.0.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the repository's tooling and agent configuration to improve reliability and performance. It introduces best practices for running long-duration tasks within agent-managed shells, updates core build dependencies, and streamlines configuration files to ensure a more consistent development environment. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The agent runs a task so long, But shells will cut it with a gong. With nohup now the job will stay, And verify the code all day. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates agent guidelines across several documentation files to advise running long-running verification commands detached via nohup to avoid shell timeouts. It also updates dependency versions in package.json and bun.lock, modifies bunfig.toml configuration (specifically minimumReleaseAge and its excludes), adds .docker.env to .gitignore, and updates the post-merge hook to clear node_modules if key bunfig.toml settings change. Feedback is provided to refine the regular expression in the post-merge hook to prevent false positives when matching configuration keys.
|
|
||
| run_if_changed "(mise\.toml|\.mise\.toml|\.tool-versions|\..+-version)" "mise install" | ||
| run_if_changed "(mise\.toml|\.mise\.toml)" "mise install" | ||
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'node_modules'; fi |
There was a problem hiding this comment.
The regular expression ^[+-] *(globalStore|linker|publicHoistPattern) matches any line starting with + or - followed by spaces and any of the keywords as a prefix (e.g., linkerOpts, globalStorePath). To prevent potential false positives from future configuration keys or comments, anchor the keywords with a word boundary (\b) or match the assignment operator (*=).
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'node_modules'; fi | |
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern) *='; then rm -Rf -- 'node_modules'; fi |
No description provided.