feat!: unify the Docker age-key plumbing on FNOX_AGE_KEY / fnox_age_key - #1199
Conversation
Drop the legacy MISE_AGE_KEY variable and mise_age_key BuildKit secret id: wb's Docker entry points now pass `--secret id=fnox_age_key,env=FNOX_AGE_KEY` whenever FNOX_AGE_KEY is set (the variable fnox itself reads and the organization already standardizes on), and `wb start`'s docker mode forwards FNOX_AGE_KEY. No backward compatibility: Dockerfiles mounting mise_age_key must switch to fnox_age_key. This removes the silent-failure mode where a caller forgot to map FNOX_AGE_KEY to MISE_AGE_KEY and the build proceeded without a key. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request simplifies the Docker build and runtime configuration by unifying the age key plumbing under the 'FNOX_AGE_KEY' identifier. By removing the manual mapping from legacy variables, the implementation reduces complexity and eliminates potential silent failures caused by missing mappings. This change is a breaking update that requires downstream repositories to align their Dockerfile configurations with the new naming standard. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The legacy key is cast aside, With FNOX now the only guide. No mapping needed, clean and bright, Our Docker builds are set aright. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Docker build and run scripts to use FNOX_AGE_KEY instead of MISE_AGE_KEY for age-key secrets and environment variables. It also updates the corresponding documentation in docs/expected-repository-rules.md to reflect this change. There are no review comments, so I have no feedback to provide.
Runtime containers get their configuration from the individually forwarded declared variables (or the platform's store), so drop the --env forwarding entirely instead of renaming it; only the build-time BuildKit secret remains. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
1 participant
Customer Summary
MISE_AGE_KEY/mise_age_keyから、fnox の正式名FNOX_AGE_KEY/fnox_age_keyに完全統一します(後方互換なし)。MISE_AGE_KEY=${FNOX_AGE_KEY}手動マッピングが不要になり、マッピング忘れで鍵が渡らず静かに失敗するモードが消えます。Technical Summary
dockerScripts.ts:project.env.FNOX_AGE_KEYが set のとき--secret id=fnox_age_key,env=FNOX_AGE_KEYを docker build に付与(旧: MISE_AGE_KEY 条件 + id=mise_age_key)。wb startの docker mode も--env FNOX_AGE_KEYを転送。docs/expected-repository-rules.md: BuildKit secret id をfnox_age_keyに更新し、wb がFNOX_AGE_KEYset 時に無条件で渡すことを明記。mise_age_keyを mount する Dockerfile(coto-world, smartse-zoom-bot)はfnox_age_keyへの追従が必要。本 PR merge 後に各リポジトリで対応します。Why
MISE_AGE_KEYは mise の sops/age 時代の残骸で、fnox は読まない。CI はFNOX_AGE_KEYを step-scoped で提供済みのため、wb がそれを直接使えば橋渡し変数と手動マッピングが丸ごと不要になる(組織方針の「実装の極限まで単純化」に合致)。Testing
bun verify(typecheck + lint)成功。リポジトリ内のMISE_AGE_KEY/mise_age_key参照はソースから消滅(dist はビルド生成物)。