Repository navigation
feat: compose customer boards and Compact portals (WI-2240) - #520
Conversation
|
Reviewed 1. [P1] Anonymous requests bypass portal admission restrictions
Require an admitted identity when the portal's admission settings restrict visitors, including when enumerating placements in 2. [P2] Disabling “My requests” also removes approval item context
The new module gate classifies every Keep the shared item-context read available to authorized active approvers when approvals are enabled; disabling the request-list module should not force approvers to decide without the request context. This finding is source-traced; the companion browser test exercises only an empty approvals list. 3. [P2] Compact routing interprets portal slugs beginning with
|
|
Size Change: 0 B 🆕 Total Size: 0 B |
|
Addressed all three findings in 85ddc7e, with companion regressions in c9f35127 (tests PR).
Qualification go test ./...
../core-tests/overlay.sh . -- -tags=test -count=1 -run 'Test(Portal|CustomerAccess|PublicBoard|Board|ManualPortal)' ./internal/handlers ./internal/restapi/v2 ./tests
../core-tests/overlay.sh . -- -tags=test -count=1 -run '^Test(Portal(BoardRequiresAdmittedIdentity|ApprovalContextWithoutRequestsModule|BoardSignedAudienceIntersectionAndLiveRevocation)|BoardPublicationPortalOnlyLifecycleAndContextIsolation)$' ./tests
../core-tests/overlay.sh . -- -tags=test -count=1 -run 'Test(ApprovalQueries|ApprovalDecisionsEnforceChannel|PortalServedWorkspace|PortalServesRequestWorkspace)' ./internal/services
VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/customer src/lib/pages/PublicBoard.test.js src/lib/stores/portalActivity.test.js src/lib/stores/portalAuth.test.js src/lib/stores/portal.test.js src/lib/api/portal.test.js
E2E_KEEP_ARTIFACTS=1 E2E_SKIP_BROWSER_INSTALL=1 ../core-tests/run-e2e.sh tests/compact-portal-workflows.spec.ts tests/portal-approval-channel-scope.spec.ts
|
Summary
Implements WI-2240's composable customer-board and Compact-portal delivery, including the reconciled WI-1662 governance foundations and WI-2194 attachment fix.
GitHub-only authentication, GitHub-organisation policy extensions, cross-site blanket sessions and customer-site product convergence remain explicitly deferred decision work (WI-2251/WI-2252).
Qualification
go test ./...in core.bun run check, Svelte type checking, changed-code Go lint.make openapi-v2-check, including generated-client compilation./windshift; no skips or retries. Includes delegated Channels and board-toolbar editing, layout round-trip, link/reload/unlink, live revoke, mobile/keyboard boards, request creation/detail/logout, draft resume, KB search/article, report/profile/approval modules, and emailed sign-in return.Integrated current
mainin both repositories (core91a122b4, tests43eeb135), preserving the incoming operator-control checks alongside the independent public-board pause. Qualification was repeated after integration. Earlier service fixture compilation limitations were resolved by the current-main integration; normal relevant service-package filters now pass on SQLite and PostgreSQL. Concurrent schema-heavy PostgreSQL broad runs exhausted the local database's shared-memory lock budget; serial focused qualification passed. The entire external regression repository was not run and is not claimed green. GitHub CI remains separate from this local qualification.Companion regression PR
Regression coverage: https://github.com/Windshiftapp/core-tests-internal/pull/55
Matching core/core-tests branch:
feat/wi-2240-composable-customer-boards.Review follow-up
Addressed all three findings in core
85ddc7e9, with regressions in companionc9f35127:Follow-up qualification passed: core
go test ./..., broader relevant SQLite handler/HTTP tests, four focused HTTP cases on PostgreSQL, approval channel/workspace service filters on both engines, 55 frontend tests, frontend check/typecheck, OpenAPI/client checks, and core commit hooks. Chromium passed nine workflow journeys plus setup at both/and/windshift, plus three board/governance journeys and setup at root; no skips/retries. The repository-wide tests no-sleep guard still fails on the pre-existingtests/attachment_upload_db_timeout_test.go:60(time.Sleep(transfer)), unchanged here; schema and browser-selector guards passed. The entire external suite was not run; CI remains separate.