Repository navigation
feat(frontend): unify canvas previews and live metadata (WI-2254) - #521
Conversation
|
Size Change: 0 B 🆕 Total Size: 0 B |
|
Reviewed [P2] Restore the visual association between condition labels and handles
In the default horizontal orientation, Please position each label next to its corresponding handle for both orientations and restore distinct branch styling. The connection E2E tests select handles by their true/false test IDs, so they pass without catching this user-visible ambiguity. Validation: Ran: VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/actions src/lib/stores/createActionFlowStore.test.js src/lib/pickers/FieldSelector src/lib/pickers/RolePickerResult: 9 files / 145 tests passed. This review did not rerun the full frontend suite, browser suites, or Go/PostgreSQL suites. |
|
Fixed the condition-branch presentation regression in
Extended the companion browser tests to check visible label text, center alignment, adjacency, matching label/handle colors and distinct outcomes before connecting the branches, then after orientation switches in both editors. With only test-ID instrumentation applied, both workflows failed against the reviewed renderer with a 138.15625px label/handle center mismatch. The failure screenshots, traces and videos are retained. Post-fix validation: E2E_KEEP_ARTIFACTS=1 ../core-tests/run-e2e.sh tests/action-canvas-preview.spec.ts
VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/actions src/lib/stores/createActionFlowStore.test.js src/lib/pickers/FieldSelector src/lib/pickers/RolePicker src/lib/locales/required-locale-coverage.test.js10 browser checks and 154 focused tests pass. App/embed builds, entry-asset check, full frontend guard and explicit changed-test Biome check pass. Companion coverage is in https://github.com/Windshiftapp/core-tests-internal/pull/56 ( |
Summary
ActionCanvasNode, shared presentation definitions and a pure plain-row formatter.WI-2254 implementation gates A/B/C1/C2 are delivered. WI-2258 and the epic remain In Progress. No backend, schema, API contract, execution, lockfile or package-manager changes. Planning and qualification documents are not committed.
Companion tests: https://github.com/Windshiftapp/core-tests-internal/pull/56, matching branch
feat/wi-2254-action-canvas-previews(commit7fef2928).Validation
From
core/:From
frontend/:bun --bun run check,bun --bun run typecheck,bun --bun run build, and explicit changed-file Biome checks pass. Typecheck reports zero errors and three existing warnings in WelcomeAssistant/TimeLogModal. Preview text is intentionally keyboard-focusable for full tooltip access without adding editing controls.Why draft / qualification blockers
The required full frontend run reports 525 passing files / 3824 passing tests; 10 failed files (three failed tests, seven import-failed suites), plus an ItemDetail unhandled rejection. Failures were independently reproduced on untouched
origin/mainate7b29449:z.configimport under Bun.The user chose to keep this PR scoped, not repair unrelated baseline failures. Assertions were not weakened and qualification is not marked complete. Go/PostgreSQL, other browsers and the full unrelated E2E suite were not run because this change does not affect backend/execution/schema behavior.