Skip to content

feat(frontend): unify canvas previews and live metadata (WI-2254) - #521

Merged
stefan-ernst merged 2 commits into
mainfrom
feat/wi-2254-action-canvas-previews
Nov 16, 2026
Merged

stefan-ernst merged 2 commits into
mainfrom
feat/wi-2254-action-canvas-previews

Conversation

@stefan-ernst

Copy link
Copy Markdown
Contributor

Summary

  • Replace 21 per-type nodes and three shared renderers with one ActionCanvasNode, shared presentation definitions and a pure plain-row formatter.
  • Show configured trigger filters, mutation effects, destinations, mappings and execution settings with honest defaults and unresolved-ID fallbacks.
  • Share live editor-owned, permission-scoped metadata with panels; preserve graph edits, positions, selection, handles and existing save normalization.
  • Bound and escape preview/tooltip text; summarize script source, HTTP headers/body and redact URLs. Add all new keys to the six full-coverage locales.

WI-2254 implementation gates A/B/C1/C2 are delivered. WI-2258 and the epic remain In Progress. No backend, schema, API contract, execution, lockfile or package-manager changes. Planning and qualification documents are not committed.

Companion tests: https://github.com/Windshiftapp/core-tests-internal/pull/56, matching branch feat/wi-2254-action-canvas-previews (commit 7fef2928).

Validation

From core/:

VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/actions src/lib/stores/createActionFlowStore.test.js src/lib/pickers/FieldSelector src/lib/pickers/RolePicker src/lib/locales/required-locale-coverage.test.js
VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh
E2E_KEEP_ARTIFACTS=1 ../core-tests/run-e2e.sh tests/action-canvas-preview.spec.ts
E2E_KEEP_ARTIFACTS=1 ../core-tests/run-e2e.sh tests/action-canvas-preview.spec.ts 'tests/action-node-config-.*\.spec\.ts' tests/action-trigger-node-config.spec.ts tests/asset-create-action-custom-fields.spec.ts tests/asset-action-workspace-permissions.spec.ts tests/manual-action-role-selector.spec.ts
  • Focused unit/component suite: 10 files, 154 tests pass.
  • Dedicated preview browser suite: 10 checks pass, including setup.
  • Broader action browser suite: 34 checks pass, including setup.
  • Original-UI regressions reproduced before implementation; browser artifacts and qualification/inventory evidence retained and attached to WI-2258.

From frontend/: bun --bun run check, bun --bun run typecheck, bun --bun run build, and explicit changed-file Biome checks pass. Typecheck reports zero errors and three existing warnings in WelcomeAssistant/TimeLogModal. Preview text is intentionally keyboard-focusable for full tooltip access without adding editing controls.

Why draft / qualification blockers

The required full frontend run reports 525 passing files / 3824 passing tests; 10 failed files (three failed tests, seven import-failed suites), plus an ItemDetail unhandled rejection. Failures were independently reproduced on untouched origin/main at e7b29449:

  • OpenUI/Homepage: undefined Zod z.config import under Bun.
  • ItemDetail: existing time-log-modal stub failure and unhandled rejection.
  • German terminology: two existing “Arbeitselement” strings.

The user chose to keep this PR scoped, not repair unrelated baseline failures. Assertions were not weakened and qualification is not marked complete. Go/PostgreSQL, other browsers and the full unrelated E2E suite were not run because this change does not affect backend/execution/schema behavior.

@github-actions

Copy link
Copy Markdown

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@stefan-ernst

Copy link
Copy Markdown
Contributor Author

Reviewed c83dc44490e066988e5df35c9d7e24b7502f303e. One actionable finding:

[P2] Restore the visual association between condition labels and handles

ActionCanvasNode.svelte:99–102

In the default horizontal orientation, getConditionOutputPositions() places the true/false handles on the right at top: 35% and top: 65%, but the new .branch-labels renders “Yes” and “No” side by side below the preview. Both handles also now receive the same yellow background; the previous renderer distinguished them with success/danger colors. Consequently, an unconnected condition in either editor has no clear visual indication of which right-hand handle represents which outcome. Users have to connect a branch before its edge label reveals the choice.

Please position each label next to its corresponding handle for both orientations and restore distinct branch styling. The connection E2E tests select handles by their true/false test IDs, so they pass without catching this user-visible ambiguity.

Validation: Ran:

VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/actions src/lib/stores/createActionFlowStore.test.js src/lib/pickers/FieldSelector src/lib/pickers/RolePicker

Result: 9 files / 145 tests passed. This review did not rerun the full frontend suite, browser suites, or Go/PostgreSQL suites.

@stefan-ernst

Copy link
Copy Markdown
Contributor Author

Fixed the condition-branch presentation regression in f9021796:

  • Labels and handles now use the same existing orientation-specific offsets, with labels adjacent to the corresponding handles outside the preview content.
  • True/false labels and handles use distinct success/danger tokens, matching their branch edges.
  • Handle IDs, connections and saved configs remain unchanged.

Extended the companion browser tests to check visible label text, center alignment, adjacency, matching label/handle colors and distinct outcomes before connecting the branches, then after orientation switches in both editors. With only test-ID instrumentation applied, both workflows failed against the reviewed renderer with a 138.15625px label/handle center mismatch. The failure screenshots, traces and videos are retained.

Post-fix validation:

E2E_KEEP_ARTIFACTS=1 ../core-tests/run-e2e.sh tests/action-canvas-preview.spec.ts
VITEST_RUNTIME=bun ../core-tests/run-overlay-script.sh . scripts/run-frontend-tests.sh src/lib/features/actions src/lib/stores/createActionFlowStore.test.js src/lib/pickers/FieldSelector src/lib/pickers/RolePicker src/lib/locales/required-locale-coverage.test.js

10 browser checks and 154 focused tests pass. App/embed builds, entry-asset check, full frontend guard and explicit changed-test Biome check pass. bun --bun run typecheck reports zero errors and three existing warnings.

Companion coverage is in https://github.com/Windshiftapp/core-tests-internal/pull/56 (b782cb27). The full unrelated frontend suite, broader action browser suite, Go/PostgreSQL and other browsers were not rerun for this presentation-only follow-up; the previously documented baseline qualification blockers remain open.

@stefan-ernst stefan-ernst changed the title feat(actions): unify canvas previews and live metadata (WI-2254) feat(frontend): unify canvas previews and live metadata (WI-2254) Nov 16, 2026
@stefan-ernst
stefan-ernst marked this pull request as ready for review November 16, 2026 13:29
@stefan-ernst
stefan-ernst merged commit dfb2c5a into main Nov 16, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant