Ignore secret values in ChatThrottleLib hooks - #26
Open
Nnoggie wants to merge 2 commits into
Open
Conversation
Nnoggie
marked this pull request as ready for review
July 16, 2026 20:30
Member
|
What exactly is the purpose of the ShouldAurasBeSecret call? All we care about is checking if the values are secret and thus strlen fails, nothing else. |
Author
|
Yeah this was a copy paste leftover from a similar fix for another AddOn. Will slim down and check for the existence of |
Nnoggie
force-pushed
the
fix/chat-throttle-secret-values
branch
from
July 16, 2026 21:13
ecd3ae0 to
f0675fc
Compare
Collaborator
|
You'll need to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ChatThrottleLib's secure hooks convert message text and destination to strings to estimate bandwidth. In restricted encounters, either value can be secret, and converting it raises an error. Ignoring those hook calls prevents the error without changing queued message delivery.