Skip to content

Ignore secret values in ChatThrottleLib hooks - #26

Open
Nnoggie wants to merge 2 commits into
WoWUIDev:masterfrom
Nnoggie:fix/chat-throttle-secret-values
Open

Ignore secret values in ChatThrottleLib hooks#26
Nnoggie wants to merge 2 commits into
WoWUIDev:masterfrom
Nnoggie:fix/chat-throttle-secret-values

Conversation

@Nnoggie

@Nnoggie Nnoggie commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • Skip bandwidth accounting when chat hooks receive secret text or destinations.
  • Avoid accessing chat values while aura secrets are active.
  • Keep Classic and older clients working when secret APIs are unavailable.
  • Bump ChatThrottleLib to version 32.

Why

ChatThrottleLib's secure hooks convert message text and destination to strings to estimate bandwidth. In restricted encounters, either value can be secret, and converting it raises an error. Ignoring those hook calls prevents the error without changing queued message delivery.

@Nnoggie
Nnoggie marked this pull request as ready for review July 16, 2026 20:30
@Nevcairiel

Copy link
Copy Markdown
Member

What exactly is the purpose of the ShouldAurasBeSecret call? All we care about is checking if the values are secret and thus strlen fails, nothing else.

@Nnoggie

Nnoggie commented Jul 16, 2026

Copy link
Copy Markdown
Author

Yeah this was a copy paste leftover from a similar fix for another AddOn. Will slim down and check for the existence of issecretvalue as well.

@Nnoggie
Nnoggie force-pushed the fix/chat-throttle-secret-values branch from ecd3ae0 to f0675fc Compare July 16, 2026 21:13
@funkydude

Copy link
Copy Markdown
Collaborator

You'll need to add issecretvalue to the .luacheckrc file so this PR passes the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants