Fix SYSMETRIC() by going through GetSystemMetrics() - #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1864
I was trying to figure out why some SYSMETRIC() values didn't match VFP and found it in the help: the Remarks say SYSTEMETRIC() is basically GetSystemMetrics(). We weren't calling it. Every element was approximated with a .NET SystemInformation property.
I ran all 34 elements against a real VFP 9 on my machine and 15 came out wrong. Changed the SWITCH to call GetSystemMetrics() with the matching SM_ index, and now 32 of 34 match.