Conversation
XiaoCow666
requested changes
Sep 15, 2026
XiaoCow666
left a comment
Owner
There was a problem hiding this comment.
结论:需要补齐阶段 13 的必要交付证据。仅静态审查所提供的 diff,未调用工具或执行测试;未发现可由这些片段直接确认的功能或安全阻塞问题。
必要修改项
- [P2] 当前交付与阶段 13 任务不对应,任务台四个证据字段全部为空。
- 位置:
KNOWLEDGE_RAG_STAGE12.md的“观察与可证伪假设”“实际结果”,以及 TASK CONTEXT 的reproduction_evidence、planned_changes、learning_summary、verification_result。 - 证据与影响:文档明确标注
stage12;所述瓶颈是原有 8 条候选截断。diff 确实包含扩大候选池、向量检索和回归测试,但没有证明阶段 13 当前的可靠性或容量缺口,也未说明选题如何避免与其他成员重复。不能据此确认本次阶段任务完成。 - 请打开
KNOWLEDGE_RAG_STAGE12.md的上述标题,保留阶段 12 历史记录;另新增KNOWLEDGE_RAG_STAGE13.md,记录当前基线的具体输入、预期与实际结果,选择一个不重复且可回滚的子问题,并提交对应行为改动和回归测试,不要仅将阶段编号改成 13。 - 请把任务台空字段改为具体证据:
reproduction_evidence填基线提交、复现命令和实际输出;planned_changes填选题、去重依据、修改位置及回滚办法;learning_summary填观察、取舍与局限;verification_result填修改后提交、命令、退出码和结果。然后运行python -m pytest tests/test_knowledge_eval.py tests/test_knowledge_vector_store.py tests/test_knowledge_rag.py -q --disable-warnings、python -m services.knowledge_eval及git diff --check,并记录所选子问题新增回归的结果。
- 位置:
已检查范围与后续建议
- 已检查评估标签、Recall 分母与去重逻辑、64 条候选和 8 条证据边界、请求内索引、异常回退及新增测试。最后一题两个相关文档、top-k=1 对应 Recall=0.5,逻辑一致。
- PR 正文称只修改 fixture、断言和文档,但提供的 diff 还新增两个服务模块并修改运行时检索。建议按实际 diff 重写变更范围,列出候选池扩大和检索模式变化,便于首次审阅者准确判断影响。
- 验证记录请继续区分当前提交的定向结果与旧提交的全量结果;正文中的通过数量属于贡献者报告,本次未独立验证。
Contributor
Author
|
该 PR 因 #51 为 squash 合并,导致历史分支展示为整组重复 diff。已从当前 main 新建干净跟进分支,仅保留 3 个文件的评审修正,并提交到后续 PR #53:https://github.com/XiaoCow666/CodeSense/pull/53。请以 #53 为准。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更范围
这是阶段十二 PR #51 合并后的跟进修订,只修正离线评估样本的事实标签,并补充可复核的验证与维护者抽查答复。目标分支为
main,当前 head 为fc7e45f35df8e76d10167a91bf18df2f2e2f2b72。tests/fixtures/knowledge_rag_eval.json:新增真实的array-indexing数组下标文档,将“下标”问题的相关文档从误标的sorting-stability改为array-boundary与array-indexing。tests/test_knowledge_eval.py:锁定最后一题 top-k=1 的实际结果与 0.5 Recall,防止评估标签和行为再次脱节。KNOWLEDGE_RAG_STAGE12.md:刷新当前 head 的验证结果,明确旧全量结果所属提交,并回答 64/8 边界和空索引/无匹配索引的回退路径。与 PR #51 评审意见的对应
sorting-stability不是数组下标文档,已替换为array-indexing;Recall 仍按真实相关文档数计算,最后一题在 top-k=1 下为 0.5。fc7e45f。旧提交d370b5f的全量回归结果仍明确标注为旧提交,不冒充本次修订后的结果。MAX_INDEX_DOCUMENTS=64控制索引候选读取范围,ID10 在范围内、ID70 被截断;MAX_EVIDENCE=8只控制最终证据数量。空索引的“数据库迁移”走no_result/NO_KNOWLEDGE_EVIDENCE;有数组/指针文档但无匹配时走priority_fallback,返回已有优先级证据以保持阶段 11 兼容行为。验证命令与结果
使用隔离 worktree 和共享
student-evalPython 环境;未使用生产数据库、Redis、外部 AI 或生产凭据。python -m pytest tests/test_knowledge_eval.py tests/test_knowledge_vector_store.py tests/test_knowledge_rag.py -q --disable-warnings:19 passed,退出码 0,37.93s。python -m services.knowledge_eval:5 个问题、4 个有标注问题;Recall@1=0.875,Recall@k=0.875;模式为 vector 3、keyword_fallback 1、no_result 1;expected mode mismatch=0;共索引 16 个切片。普通问题构建 mean/P95=0.341/1.477ms,查询=0.045/0.094ms,合计=0.387/1.532ms;64 文档性能样本构建=0.946ms,查询 mean/P95=0.392/0.660ms,总耗时=40.161ms,摊销=0.402ms/次。git diff --check:通过。d370b5f已验证全量python -m pytest -q --disable-warnings:681 passed,13:26;本次跟进只涉及评估 fixture、评估断言和文档,当前全量结果未重新宣称。事实与推断边界
后续
请按
main当前状态复核并合并本跟进 PR;若仍需全量回归或网络侧 merge-precheck,请以新 headfc7e45f重跑。阶段十二 PR #51 已合并,本 PR 仅承接其评审反馈中的事实记录修正。