Skip to content

fix: distinguish unavailable sandbox results #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaoCow666 merged 1 commit into from
Sep 18, 2026
Merged

fix: distinguish unavailable sandbox results #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions templates/submission_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,15 +267,15 @@ <h2 class="mb-3">{{ assignment.title }}</h2>
<span class="ms-1 badge badge-score-{{ submission.score|round|int }} fs-6">
{{ submission.score }} / 5
</span>
{% if submission.sandbox_total is not none %}
{% if submission.sandbox_status == 'unavailable' %}
<span class="ms-2 badge bg-secondary">
<i class="bi bi-exclamation-triangle me-1"></i> 测试环境未就绪
</span>
{% elif submission.sandbox_total is not none %}
<span
class="ms-2 badge {% if submission.sandbox_status == 'passed' %}bg-success{% elif submission.sandbox_status == 'partial' %}bg-warning text-dark{% else %}bg-danger{% endif %}">
通过 {{ submission.sandbox_passed or 0 }}/{{ submission.sandbox_total }}
</span>
{% elif submission.sandbox_status == 'unavailable' %}
<span class="ms-2 badge bg-secondary">
<i class="bi bi-exclamation-triangle me-1"></i> 测试环境未就绪
</span>
{% endif %}
</div>
</div>
Expand Down
42 changes: 42 additions & 0 deletions tests/test_submission_knowledge_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,48 @@ def test_submission_detail_shows_knowledge_focus_and_scoring_boundary(
assert "不是本次评分依据" in html


def test_submission_detail_does_not_present_unavailable_sandbox_as_failed_score(
submission_knowledge_context, monkeypatch
):
app, client, ids = submission_knowledge_context
_login(client, "submission-evidence-student")
monkeypatch.setattr(assignment_routes, "retrieve_assignment_knowledge", _retrieval)

with app.app_context():
submission = db.session.get(Submission, ids["submission"])
submission.sandbox_status = "unavailable"
submission.sandbox_passed = 0
submission.sandbox_total = 2
db.session.commit()

response = client.get(f"/view_submission/{ids['submission']}")

assert response.status_code == 200
html = response.get_data(as_text=True)
assert "测试环境未就绪" in html
assert "通过 0/2" not in html


def test_submission_detail_keeps_passed_sandbox_badge(
submission_knowledge_context, monkeypatch
):
app, client, ids = submission_knowledge_context
_login(client, "submission-evidence-student")
monkeypatch.setattr(assignment_routes, "retrieve_assignment_knowledge", _retrieval)

with app.app_context():
submission = db.session.get(Submission, ids["submission"])
submission.sandbox_status = "passed"
submission.sandbox_passed = 2
submission.sandbox_total = 2
db.session.commit()

response = client.get(f"/view_submission/{ids['submission']}")

assert response.status_code == 200
assert "通过 2/2" in response.get_data(as_text=True)


def test_submission_access_is_checked_before_knowledge_retrieval(
submission_knowledge_context, monkeypatch
):
Expand Down
Loading