Skip to content

Fix REALITY initialization on Windows ARM64 - #6

Merged
yiguodev merged 3 commits into
releasefrom
fix/reality-windows-arm64
Nov 20, 2026
Merged

yiguodev merged 3 commits into
releasefrom
fix/reality-windows-arm64

Conversation

@yiguodev

@yiguodev yiguodev commented Nov 20, 2026 •

Copy link
Copy Markdown

Summary

- reality_client.emplace();
+ reality_client.emplace(SSL_CONFIG::RealityClient{});

Construct the aggregate explicitly so std::optional does not need to evaluate the nested type's zero-argument constructibility. Add a native Windows ARM64 build check for PRs into release with the fork TLS extensions enabled.

Evidence

  • Windows ARM64 with clang-cl 22.1.8 and MSVC STL 14.52 rejected the original call in ssl_lib.cc.
  • A focused C++ type model reproduced the overload failure and compiled with the explicit aggregate. On macOS ARM64, all 43 focused REALITY, fingerprint and HKDF tests passed.
  • The Windows ARM64 build passed on the Boring 5.5.1 base with the original toolchain versions (clang-cl 22.1.8, MSVC 14.52.37025).

Merge Danger

Revertible. The C++ change is limited to initial construction of the existing REALITY state. The pinned BoringSSL gitlink and aggregate layout are unchanged.

Copilot AI balanced review requested due to automatic review settings November 20, 2026 00:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T00:57:40.696612Z 83c340b New commits
🔒 Security Review ✅ Completed 2026-11-20T00:59:06.371222Z 83c340b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the Windows ARM64 initialization fix and added TLS build check.

No open issues 🎉

What changed in this PR

This PR fixes REALITY client initialization on Windows ARM64 and adds a native build check for the fork’s TLS extensions.

Changes:

  • Explicitly constructs SSL_CONFIG::RealityClient{} before passing it to std::optional::emplace, avoiding the reported zero-argument constructibility failure.
  • Adds a Windows ARM64 workflow for PRs targeting release, checking boring-sys with client-fingerprint and jls enabled.
File Description
boring-sys/​patches/​reality-client.patch Uses explicit aggregate construction for the existing REALITY state.
.github/​workflows/​windows-arm64-tls.yml Adds a native ARM64 Cargo check using clang-cl, Ninja, and an explicit CMake toolchain.

Review effort: Balanced

@yiguodev
yiguodev merged commit 11b9494 into release Nov 20, 2026
3 of 4 checks passed
@yiguodev
yiguodev deleted the fix/reality-windows-arm64 branch November 20, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants