Repository navigation
Fix REALITY initialization on Windows ARM64 - #6
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Windows ARM64 initialization fix and added TLS build check.
No open issues 🎉
What changed in this PR
This PR fixes REALITY client initialization on Windows ARM64 and adds a native build check for the fork’s TLS extensions.
Changes:
- Explicitly constructs
SSL_CONFIG::RealityClient{}before passing it tostd::optional::emplace, avoiding the reported zero-argument constructibility failure. - Adds a Windows ARM64 workflow for PRs targeting
release, checkingboring-syswithclient-fingerprintandjlsenabled.
| File | Description |
|---|---|
boring-sys/patches/reality-client.patch |
Uses explicit aggregate construction for the existing REALITY state. |
.github/workflows/windows-arm64-tls.yml |
Adds a native ARM64 Cargo check using clang-cl, Ninja, and an explicit CMake toolchain. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Construct the aggregate explicitly so
std::optionaldoes not need to evaluate the nested type's zero-argument constructibility. Add a native Windows ARM64 build check for PRs intoreleasewith the fork TLS extensions enabled.Evidence
clang-cl22.1.8 and MSVC STL 14.52 rejected the original call inssl_lib.cc.clang-cl22.1.8, MSVC 14.52.37025).Merge Danger
Revertible. The C++ change is limited to initial construction of the existing REALITY state. The pinned BoringSSL gitlink and aggregate layout are unchanged.