test: add pool concurrency coverage - #92
YuminosukeSato wants to merge 1 commit into
Conversation
github-actions
Bot
added
lang/go
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0fc73768c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "github.com/YuminosukeSato/pyproc/internal/protocol" | ||
| ) | ||
|
|
||
| func TestPoolCall_SerializesPerWorker(t *testing.T) { |
There was a problem hiding this comment.
These new tests call startUnixServer directly, which hard-fails on net.Listen("unix", ...) when Unix domain sockets are unavailable (the exact environment that requireUnixSocket is meant to skip in main_test.go). Because none of the new test functions invoke that guard, they can make CI fail in restricted or non-UDS environments instead of being skipped.
Useful? React with 👍 / 👎.
34f0c2c to
b7369b3
Compare
b0fc737 to
1b32be0
Compare
* ci: increase max-turns from 20 to 30 PR #92 used 21 turns and hit the limit. Increasing to 30 to allow more comprehensive reviews without artificial cutoffs. Observed usage: - PR #90: 18 turns (/bin/zsh.51) - PR #92: 21 turns (/bin/zsh.36) Expected cost: ~/bin/zsh.40-0.60 per PR * ci: remove Claude Code workflow Remove automated Claude Code reviews. Manual code reviews will be used instead.
b7369b3 to
04469d9
Compare
1b32be0 to
1e6b1e4
Compare
1e6b1e4 to
497844e
Compare
|
Will be included in combined stack PR targeting main |
1 participant
Summary
Changes
pool_concurrency_test.gofor dispatch/oversubscribe/shutdown scenarios.MaxInFlightPerWorker.Test plan
go test -v -race ./...