Repository navigation
Fix mutation integrity, shared sessions, and desktop audit findings - #18
Merged
Merged
Conversation
Contributor
|
Too many files changed for review (104 files, 100 file limit). Bypass the limit by tagging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeroLink could write outside a project, apply incomplete or invalid content, lose another session's drafts, and overwrite later edits during rollback. This change repairs all 17 audit findings and the associated desktop, compatibility and verification gaps.
Validation on Linux (Node 26.8.1):
npm run checkpassed 389 tests with 92.71% line / 85.08% branch coverage and all critical-directory gates;npm run buildpassed; native Electron E2E passed, including seven main-view accessibility scans, review-modal accessibility and keyboard focus;npm auditreported zero vulnerabilities;git diff --checkpassed. Original regressions and four additional independently reproduced review findings now pass, alongside successful multi-operation and multi-session controls.Compatibility changes: public apply now requires
expectedRevision; creation requires complete fields; CLI output goes to stderr; internal project symlinks are refused. Legacy pending staging and journals without post-hashes require explicit recovery. Recovery, fixture provenance and verification scope document these contracts and the unverified native Windows/macOS Electron, MZ runtime and installer paths. Original fixture data was not changed.