Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kiro/specs/accounts/requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Acceptance criteria:
2. WHEN the callback succeeds, THE SYSTEM SHALL create a session holding the GitHub user id, login, avatar URL and the user access token encrypted with AES-256-GCM, and SHALL set a session cookie that is `httpOnly`, `Secure`, `SameSite=Lax` and scoped to `/`.
3. THE SYSTEM SHALL request no OAuth scopes beyond what the GitGotchi App's permissions grant.
4. WHEN the user access token expires, THE SYSTEM SHALL refresh it with the stored refresh token. IF the refresh fails, THEN THE SYSTEM SHALL end the session and treat the user as a visitor.
5. WHEN a user selects SIGN OUT, THE SYSTEM SHALL delete the session record and clear the cookie.
5. WHEN a user selects SIGN OUT, THE SYSTEM SHALL revoke the session's GitHub user token at GitHub, delete the session record and clear the cookie.
6. THE SYSTEM SHALL keep tokens, refresh tokens and session ids out of every response body, log line and error message.

### R2. Who may do what
Expand Down
4 changes: 2 additions & 2 deletions src/app/privacy/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default function PrivacyPage() {

<Section title="WHERE AND HOW LONG">
<ul className="list-inside list-disc space-y-1">
<li>The app runs on Vercel. Pets and sessions are stored in Upstash Redis (region us-east-1), over TLS.</li>
<li>The app runs on Vercel. Pets and sessions are stored in Upstash Redis (region us-east-1), over TLS. Sign in passes through gitgochi.vercel.app, which hands the session back with a one-time ticket and keeps no cookie.</li>
<li>Pets stay until a keeper deletes them, or, for private repos, until the app is uninstalled from the repo.</li>
<li>Sessions end when you sign out, or 30 days after their last use.</li>
<li>Demo pets are stored only in your own browser.</li>
Expand All @@ -65,7 +65,7 @@ export default function PrivacyPage() {
<ul className="list-inside list-disc space-y-1">
<li>Keepers: DELETE PET on the pet page removes its stats, history, badge key and tokens at once.</li>
<li>Uninstalling the app from a private repo deletes its pet.</li>
<li>SIGN OUT deletes your session and its tokens. You can also revoke GitGotchi in your GitHub settings under Applications.</li>
<li>SIGN OUT deletes your session and revokes its GitHub token at GitHub, so a copy of the token stops working. You can also revoke GitGotchi in your GitHub settings under Applications.</li>
</ul>
</Section>
</main>
Expand Down
Loading