🧪 Add unit tests for wait_connected method in MQTT client#10
Conversation
Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
🎯 What: Added tests for the previously untested
wait_connectedmethod in theRuViewMqttClient.📊 Coverage: Covered default timeout argument, custom timeout argument, and propagation of boolean return values representing connection success and timeout failure.
✨ Result: Increased unit test coverage and confidence in the MQTT client lifecycle methods without needing a real broker connection.
PR created automatically by Jules for task 17413907925505756645 started by @manupawickramasinghe