Skip to content

🧪 Add unit tests for wait_connected method in MQTT client#10

Merged
ManupaKDU merged 3 commits into
mainfrom
test-wait-connected-17413907925505756645
Jul 26, 2026
Merged

🧪 Add unit tests for wait_connected method in MQTT client#10
ManupaKDU merged 3 commits into
mainfrom
test-wait-connected-17413907925505756645

Conversation

@manupawickramasinghe

Copy link
Copy Markdown
Member

🎯 What: Added tests for the previously untested wait_connected method in the RuViewMqttClient.
📊 Coverage: Covered default timeout argument, custom timeout argument, and propagation of boolean return values representing connection success and timeout failure.
✨ Result: Increased unit test coverage and confidence in the MQTT client lifecycle methods without needing a real broker connection.


PR created automatically by Jules for task 17413907925505756645 started by @manupawickramasinghe

Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 26, 2026 09:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

google-labs-jules Bot and others added 2 commits July 26, 2026 11:20
Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Adds unit test coverage for the `wait_connected` method in `RuViewMqttClient` by using `unittest.mock.patch.object` to verify the delegation to `threading.Event.wait` with appropriate timeout arguments and return values.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@ManupaKDU
ManupaKDU merged commit d8d8b8a into main Jul 26, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants