Skip to content

⚡ Perf: Optimize nested loop linear search to O(N log M)#16

Merged
ManupaKDU merged 1 commit into
mainfrom
optimize-find-loop-14545696987143958626
Jul 26, 2026
Merged

⚡ Perf: Optimize nested loop linear search to O(N log M)#16
ManupaKDU merged 1 commit into
mainfrom
optimize-find-loop-14545696987143958626

Conversation

@manupawickramasinghe

Copy link
Copy Markdown
Member

💡 What: Replaced an Array.prototype.find() call nested inside a loop with a pre-indexed Map and binary search lookup in scripts/train-camera-free.js.
🎯 Why: Searching through a large array linearly for each element of another large array resulted in O(N*M) time complexity. By pre-grouping by nodeId, sorting by timestamp, and performing a binary search, this lookup operates in O(N log(M/K)) time. Additionally, this optimization tracks the original array index and scans locally around the binary search result to guarantee the return matches the first match in the original array, perfectly preserving the original .find() semantics.
📊 Measured Improvement: Baseline (20k x 20k entries): ~2.4 seconds -> Optimized (20k x 20k entries): ~32ms (~75x latency improvement).


PR created automatically by Jules for task 14545696987143958626 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 26, 2026 09:51
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ManupaKDU
ManupaKDU merged commit 91d61f9 into main Jul 26, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants