Feat(desktop): Cmd+Q closes the window without quitting the app - #704
Open
junereycasuga wants to merge 1 commit into
Open
Feat(desktop): Cmd+Q closes the window without quitting the app#704junereycasuga wants to merge 1 commit into
junereycasuga wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #701
Summary
On macOS, pressing
Cmd+Qpreviously fully quit ZenNotes. This PR changes it soCmd+Qcloses the active/main workspace window while leaving the app process running in the background. A new "Completely Quit ZenNotes" menu item is added for users who want to fully exit.This also keeps Quick Capture usable even when the main note window is closed.
What changed
role: "quit"item with a custom "Close Window" item bound toCmdOrCtrl+Q.Cmd+QclosesBrowserWindow.getFocusedWindow()(falling back tomainWindow).window-all-closedalready keeps the process alive, so the app stays in the background.ZenNotesmenu, which callsapp.quit().Why
zn openwithout a cold start.Notes
This only affects the macOS menu bar because Windows/Linux currently hide the application menu (
autoHideMenuBar: true). The change is scoped toapps/desktop/src/main/index.ts.