Repository navigation
Conversation
minio/minio and minio/mc are gone from Docker Hub and Quay, so the Helm chart and deploy/compose pins no longer pull. Use cgr.dev/chainguard/minio and minio-client (free, latest-dev pinned by digest; -dev carries the /bin/sh the init steps run). The image runs as uid 65532 and has wget but no curl, so the compose healthcheck uses wget and the chart's MinIO pod sets fsGroup 65532. Tested: deploy/compose minio + minio-init (bucket private, write/read ok); chart quickstart render, then MinIO Deployment, init Job and the relay's wait-for-bucket step on Kubernetes with a PVC. Signed-off-by: wiggdevin <202901685+wiggdevin@users.noreply.github.com>
Sol review: volumes written by the root-run minio/minio image are root-owned, so the uid-65532 Chainguard image could not write them after an upgrade, and fsGroup does not fix hostPath PVCs. Add a one-shot root chown before MinIO starts (compose service minio-perms, chart initContainer data-ownership). Tested: data written by a root-run MinIO stays readable and new writes work. Signed-off-by: wiggdevin <202901685+wiggdevin@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 13, 2026
Review of the Chainguard MinIO switch (GPT-6.1 Sol, Grok, Opus) found the root chown hand-over unsafe on reruns: - compose: `up`/`run.sh restart` reruns minio-perms while MinIO serves. A file deleted mid-walk made `chown -R` exit non-zero and the relay never started. The step now skips the walk when nothing under /data is left to hand over, tolerates vanishing files, and fails only when ownership is still wrong afterwards. It runs with no network and a com.buzz label. - chart: the same guard in the data-ownership initContainer, so a reschedule costs one find instead of a full-tree walk. New minio.fixDataOwnership (default true) drops the root initContainer for NFS root_squash storage and PSA-restricted namespaces; minio.podSecurityContext makes the pod context configurable and adds fsGroupChangePolicy: OnRootMismatch. - renovate: weekly, never-automerged digest bumps for cgr.dev/chainguard, since superseded free-tier digests are not retained. - ARCHITECTURE.md: MinIO image row now covers compose and the chart. - helm-unittest: default hand-over and the opt-out path. Verified locally: compose run on a root-owned volume (migrates), rerun on a migrated volume (skips), rerun under concurrent deletes (exit 0), MinIO healthy and bucket init OK; helm unittest 49/49, lint and every fixture render clean with helm v3.16.4 + helm-unittest 0.8.2. Signed-off-by: wiggdevin <202901685+wiggdevin@users.noreply.github.com>
…scanned Re-review (GPT-6.1 Sol) found the guard treated a failed find as "nothing left to hand over": on root-squashed NFS with a 0700 /data, the root step could not enumerate legacy root-owned files and exited 0, leaving MinIO on unreadable data. The image's find is BusyBox, which has no -ignore_readdir_race and exits non-zero on entries that vanish mid-walk. The guard now reads find's error lines instead of its exit code: "No such file or directory" (files removed while MinIO serves) is tolerated, any other error fails the step with the find message. Verified with real containers: migration under concurrent renames, reruns on a migrated volume with and without churn (skip path), MinIO healthy, and an unreadable /data (root without DAC caps) now exits 1 with "cannot scan /data: Permission denied". helm unittest 49/49, lint and all fixture renders clean; the rendered chart script migrates a root-owned volume in the image. Signed-off-by: wiggdevin <202901685+wiggdevin@users.noreply.github.com>
Review fixes (Sol: no findings above NIT; Argon: 1 BLOCK, 4 WARN, verified): - chown -Rh so root-owned symlinks in /data are re-owned, not followed (compose minio-perms and chart data-ownership initContainer). - README: stop relay and minio and back up the volume before the first upgrade, because minio-perms must not run beside the old root-run container (compose starts dependencies before it stops the old one). - renovate: customManager for minio.mcImage, which the helm-values manager does not read, so its digest is refreshed with the minio image. - Record the minio RELEASE behind each digest; correct ARCHITECTURE.md (dev and CI compose files track latest-dev) and the PSA/OpenShift comment in values.yaml. Signed-off-by: wiggdevin <202901685+wiggdevin@users.noreply.github.com>
wiggdevin
marked this pull request as draft
October 28, 2026 03:44
wiggdevin
marked this pull request as ready for review
October 28, 2026 03:45
wiggdevin
marked this pull request as draft
October 28, 2026 03:52
wiggdevin
marked this pull request as ready for review
October 28, 2026 03:52
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 10, 2026
wiggdevin
marked this pull request as draft
November 10, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minio/minio and minio/mc left Docker Hub and Quay, so production Compose and the chart quickstart now pull Chainguard's free MinIO images, pinned by digest.
Commits
Review
Audited by GPT-6.1 Sol, Grok and Opus. Verified findings were fixed in the last two commits:
chown -Ron everyupwhile MinIO served. A file deleted mid-walk failed the step and kept the relay down. The step now skips when ownership is already right and tolerates vanishing files.minio.fixDataOwnershipandminio.podSecurityContext(withfsGroupChangePolicy: OnRootMismatch).cgr.dev/chainguard/**weekly and never automerges.Grok's BLOCK (the image CMD appended to the chown entrypoint) and its wget-HSTS and
mcconfig concerns were checked against the images and do not apply. The images have an empty CMD and$HOMEis writable by uid 65532.Test plan
Not verified: whether data written by upstream RELEASE.2025-09-07 opens cleanly in RELEASE.2026-09-22. The old image can no longer be pulled. Back up
buzz-minio-databefore upgrading a live server.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.