uf2: adapt to 0.17 API, add file tracking support - #994
Open
by965738071 wants to merge 8 commits into
Open
Conversation
by965738071
force-pushed
the
uf2-file-tracking
branch
from
July 23, 2026 23:26
50bdfe1 to
e8aad5b
Compare
Grazfather
reviewed
Jul 24, 2026
Grazfather
left a comment
Grazfather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I will test this out shortly
Contributor
Author
|
@Grazfather I have removed the unused code. |
Grazfather
reviewed
Jul 25, 2026
| errdefer _ = self.blocks.pop(); | ||
|
|
||
| const block = &self.blocks.items[self.blocks.len - 1]; | ||
| const block = &self.blocks.items[self.blocks.items.len - 1]; |
Collaborator
There was a problem hiding this comment.
How did this ever work?
…, simplify redundant if, use English comments
Grazfather
reviewed
Jul 28, 2026
Grazfather
left a comment
Grazfather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. A few nitpicks and a question about a test remain.
Grazfather
reviewed
Jul 29, 2026
Grazfather
approved these changes
Jul 30, 2026
Grazfather
left a comment
Grazfather
left a comment
Collaborator
There was a problem hiding this comment.
Thank you. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.