Repository navigation
Conversation
Signed-off-by: Robert Washbourne <rawashbourne@gmail.com>
Signed-off-by: Robert Washbourne <rawashbourne@gmail.com>
Collaborator
Author
|
Superseded by normally merged PR16, which includes these annotation fixes and passes the complete release test/backend and pre-commit workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release branch reports 22 mypy errors because checkpoint annotations still describe the former synchronous None-only API and homogeneous snapshot dictionaries. Match the existing receipt/phase contract, annotate Future[None] and mixed storage identities, and narrow the already-validated gather results. The explicit controller return preserves its existing implicit None behavior. No checkpoint algorithm, storage operation or wire format changes.
The same 22 file/line/message findings were reproduced by ordinary CI on workflow-only PR16 against release9c2365a and codec PR15. Ruff, formatting and diff checks pass; normal pre-commit execution is pending. Full release test coverage is tracked separately by PR16; no required-check override is requested.
AI assistance: Codex.