Repository navigation
fix: preserve controller tags during fields-only KV writes - #18
Merged
Merged
Conversation
Signed-off-by: Robert Washbourne <rawashbourne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fields-only KV write currently republishes the tags retrieved before its payload write. If another producer updates those tags while the storage write runs, that stale snapshot overwrites the newer controller state.
Use the same payload implementation without tag publication when a KV caller omits
tag/tags. Explicit tags and tags-only calls still publish; public clientput/async_putstill publish suppliedBatchMeta.custom_meta. Storage settlement, field readiness and returned metadata remain unchanged. Returned tags are a snapshot, with no new atomicity guarantee.Validation: 38 owning cases passed (12 new sync/async single/batch interleaving and failure controls, 26 existing KV/client regressions), zero skips, against private local Ray/SimpleStorage under the existing runtime. Compileall, Ruff and format checks passed. Tests record actual controller SET counts and time. This does not establish a production throughput gain or qualify a runtime wheel.
AI assistance: implemented and reviewed with Codex.