refactor(server): small perfromance improvement when database task store is used - #671
Open
RonaldMarske wants to merge 4 commits into
Open
refactor(server): small perfromance improvement when database task store is used#671RonaldMarske wants to merge 4 commits into
RonaldMarske wants to merge 4 commits into
Conversation
🧪 Code Coverage
Generated by coverage-comment.yml |
Co-authored-by: bartek-gralewicz <bgralewicz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid loading the Task twice from the TaskStore
What changed
In
DefaultRequestHandler,_mapEventToStreamResponsenow reads the full Taskfrom the
ResultManager(getCurrentTask()) instead of re-loading it from theTaskStorefortaskevents. It is now synchronous, and the output isunchanged (the
|| event.datafallback stays).Why
We run a database-backed store, so re-reading the Task is a round-trip per
streamed
taskevent that adds up under load. It is pure overhead:processEvent, run immediately before, has already built that Task. (Free onthe in-memory store.)