Repository navigation
Refactor index generator to class that exposes progress - #888
Merged
Merged
Conversation
chvp
reviewed
Oct 30, 2026
chvp
left a comment
chvp
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just one small question.
robbevp
enabled auto-merge (squash)
October 31, 2026 12:20
chvp
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on accentor/web#1596, I wanted to be able to know the progress of the index action. We can currently only call
next()and just know when it is done.I refactored our
indexGeneratorfunction to anIndexGeneratorclass that responds tonext()with the same value as before, but also allows access tototalPages,currentPageandprogress. (Though this technically isn't a JS generator, I looked into declaring this class withclass IndexGenerator implements AsyncGenerator, but then I also needed to implementthrow()andreturn(), these methods IMHO don't make a lot of sense in our context)This probably requires some changes to types in TS projects, but functionally should be the same