Repository navigation
Add support to GitCmd - #916
Conversation
|
(and idea itself is good) |
|
thanks! |
|
please also rebase on top of master branch, to make the CI pass |
1434314 to
5f90a47
Compare
|
now you need to resolve the actual codestyle mismatches CI found: https://github.com/actionless/pikaur/actions/runs/33690974456/job/100483572792?pr=916 |
|
CI is still failing |
you know, you could run CI locally? 😺 https://github.com/actionless/pikaur/blob/master/README.md#code |
|
:face_palme: I miss the Contributing section. |
that's weird - it must work that way, what was the exact cli args? |
Coverage Report for CI Build 34435175912Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.2%) to 83.321%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions148 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
|
i was about to merge but whilst writing commit message i've realized the problem with naming - it turns GitDiffArgs into GitCmd, instead of GitDiffCmd - which is pretty confusing |
|
Agreed, I renamed the config |
|
thanks for your contribution! |
Goal
I wanna use difftastic to see PKGBUILD files diff
Solution
I allow to specify the git command to use
git -C {{repo_path}} diff --ignore-space-change --ignore-all-space {{last_install_hash}} {{current_hash}} -- .It allso has some "params" for variables.
Originally I implemented a "GitDiffExternalTool" but then I realize any new feature we would need yet an other params so instead I went with something more generic
Looking for feedback
So this solution works, I didn't test it like crazy yet, I'm looking on feedback like is this okay to let the user specify the full git command? This also deprecate the GitDiffArgs param, I could also put it as a replacable var? Or I can go back to a more specific approach of a GitDiffExternalTool.