Skip to content

Add support to GitCmd - #916

Merged
actionless merged 8 commits into
actionless:masterfrom
Aurze:add-support-for-custom-git-command
Sep 10, 2026
Merged

actionless merged 8 commits into
actionless:masterfrom
Aurze:add-support-for-custom-git-command

Conversation

@Aurze

@Aurze Aurze commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Goal

I wanna use difftastic to see PKGBUILD files diff

Solution

I allow to specify the git command to use git -C {{repo_path}} diff --ignore-space-change --ignore-all-space {{last_install_hash}} {{current_hash}} -- .
It allso has some "params" for variables.

Originally I implemented a "GitDiffExternalTool" but then I realize any new feature we would need yet an other params so instead I went with something more generic

Looking for feedback

So this solution works, I didn't test it like crazy yet, I'm looking on feedback like is this okay to let the user specify the full git command? This also deprecate the GitDiffArgs param, I could also put it as a replacable var? Or I can go back to a more specific approach of a GitDiffExternalTool.

Comment thread pikaur/install_cli.py
@actionless

Copy link
Copy Markdown
Owner

(and idea itself is good)

Comment thread pikaur/install_cli.py Outdated
Comment thread pikaur/install_cli.py Outdated
@actionless

Copy link
Copy Markdown
Owner

thanks!

@actionless

Copy link
Copy Markdown
Owner

please also rebase on top of master branch, to make the CI pass

@Aurze
Aurze force-pushed the add-support-for-custom-git-command branch from 1434314 to 5f90a47 Compare September 2, 2026 22:33
@actionless

Copy link
Copy Markdown
Owner

now you need to resolve the actual codestyle mismatches CI found:

https://github.com/actionless/pikaur/actions/runs/33690974456/job/100483572792?pr=916

@actionless

Copy link
Copy Markdown
Owner

CI is still failing

@actionless

actionless commented Sep 7, 2026 •

Copy link
Copy Markdown
Owner

hopefully

you know, you could run CI locally? 😺

https://github.com/actionless/pikaur/blob/master/README.md#code

@Aurze

Aurze commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

:face_palme: I miss the Contributing section.
Okay so now lint pass on my side but for ./maintenance_scripts/docker_test.sh it says you can use "all" as a module but when I do so it says module not found. So I ran a bunch manually. If I miss some, sorry. But is there a way to run all test?

@actionless

actionless commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

for ./maintenance_scripts/docker_test.sh it says you can use "all" as a module but when I do so it says module not found

that's weird - it must work that way, what was the exact cli args?

@coveralls

coveralls commented Sep 10, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 34435175912

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.2%) to 83.321%

Details

  • Coverage increased (+0.2%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • 148 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

148 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
pikaur/install_cli.py 88 73.96%
pikaur/privilege.py 29 32.84%
pikaur/args.py 28 89.78%
pikaur/help_cli.py 3 91.43%

Coverage Stats

Coverage Status
Relevant Lines: 5510
Covered Lines: 4591
Line Coverage: 83.32%
Coverage Strength: 0.83 hits per line

💛 - Coveralls

@actionless

Copy link
Copy Markdown
Owner

i was about to merge but whilst writing commit message i've realized the problem with naming - it turns GitDiffArgs into GitCmd, instead of GitDiffCmd - which is pretty confusing

@Aurze

Aurze commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Agreed, I renamed the config

@actionless
actionless merged commit 6bc20bd into actionless:master Sep 10, 2026
12 checks passed
@actionless

Copy link
Copy Markdown
Owner

thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants