ci: use read-only npm caches for validation - #270
Open
philip-gai wants to merge 1 commit into
Open
philip-gai wants to merge 1 commit into
philip-gai wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens CI cache behavior by making validation-only workflows (linting and license checks) consume existing npm caches without being able to write/update them, reducing cache-poisoning risk while keeping cache speedups.
Changes:
- Set
cache-mode: readon thelintjob in.github/workflows/linter.yml. - Set
cache-mode: readon thelicensedjob in.github/workflows/licensed.yml.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/linter.yml | Makes the lint job restore npm caches without saving/updating them. |
| .github/workflows/licensed.yml | Makes the license-check job restore npm caches without saving/updating them. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-mode: readon thelintjob.cache-mode: readon thelicensedjob.Validation
npm exec --no -- prettier --check .github/workflows/linter.yml .github/workflows/licensed.ymljs-yamldependency.npm test -- --reporter=dot(4 files, 36 tests passed)