[All OSs] Fix SBOM release asset upload and duplicate scan runs - #14637
Open
v-dunjadenic wants to merge 2 commits into
Open
v-dunjadenic wants to merge 2 commits into
v-dunjadenic wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SBOM-generation workflow to make release-asset uploads idempotent and to avoid duplicate, concurrent SBOM scans for the same release.
Changes:
- Switches release asset upload from
actions/upload-release-asset@v1togh release upload --clobber. - Adds workflow-level
concurrencykeyed by release ID to serialize SBOM runs per release. - Extends the workflow
run-nameto include the dispatch ID for easier run correlation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
v-dunjadenic
marked this pull request as ready for review
August 26, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
actions/upload-release-asset@v1withgh release upload --clobber.actions/upload-artifactfrom v4 to v6.concurrencygroup keyed on the release ID.run-name.Reasoning:
When more than one run is dispatched for the same release, both scan concurrently and the second upload fails with a bare
Validation Failed. That is all the archived action reports. It drops the API error details, so the actual cause (already_exists) never appears in the log.--clobbermakes the upload idempotent, and the concurrency group stops a second run from repeating a multi-hour scan that has already been done. The archived action was last updated in 2021, targets Node 20, and uses the deprecatedset-output.actions/upload-artifact@v4was named in the same Node 20 deprecation warning. v6 is the first major to run on Node 24; its inputs are unchanged from v4, and it requires runner 2.327.1 or newer, which these runners already exceed.Related issue:
Tracked privately
Check list