Conversation
Latest NDK LTS is 30, so following the NDK versioning policy all images now use 28 as the default, and 29 and 30 available as well. In the meantime, the Windows on ARM runners now match the standard 2025 runners w.r.t Android CMake versions. Signed-off-by: crueter <crueter@eden-emu.dev>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Windows ARM64 Android entries are neither installed nor validated, leaving the advertised NDK/CMake updates unresolved.
Pull request overview
Updates Android NDK availability across Ubuntu, Windows, and macOS images, setting NDK 28 as default and providing versions 28–30. Windows ARM64 Android CMake versions are also aligned with standard 2025 runners.
Changes:
- Updates NDK toolsets, reports, and environment paths.
- Aligns Windows ARM64 CMake packages.
- Windows ARM64 Android entries remain uninstalled and unvalidated.
File summaries
| File | Summary |
|---|---|
images/windows/Windows2025-VS2026-Readme.md |
Updates NDK reports and paths. |
images/windows/Windows2025-Readme.md |
Updates NDK reports and paths. |
images/windows/Windows2022-Readme.md |
Updates NDK reports and paths. |
images/windows/toolsets/toolset-win-11-vs2026-arm64.json |
Updates ARM64 NDK and CMake entries. |
images/windows/toolsets/toolset-win-11-arm64.json |
Updates ARM64 NDK and CMake entries. |
images/windows/toolsets/toolset-2025.json |
Updates NDK versions. |
images/windows/toolsets/toolset-2025-vs2026.json |
Updates NDK versions. |
images/windows/toolsets/toolset-2022.json |
Updates NDK versions. |
images/ubuntu/Ubuntu2604-Readme.md |
Updates NDK reports and paths. |
images/ubuntu/Ubuntu2404-Readme.md |
Updates NDK reports and paths. |
images/ubuntu/Ubuntu2204-Readme.md |
Updates NDK reports and paths. |
images/ubuntu/toolsets/toolset-2604.json |
Updates NDK versions. |
images/ubuntu/toolsets/toolset-2604-arm64.json |
Updates ARM64 NDK versions. |
images/ubuntu/toolsets/toolset-2404.json |
Updates NDK versions. |
images/ubuntu/toolsets/toolset-2404-arm64.json |
Updates ARM64 NDK versions. |
images/ubuntu/toolsets/toolset-2204.json |
Updates NDK versions. |
images/ubuntu/toolsets/toolset-2204-arm64.json |
Updates ARM64 NDK versions. |
images/macos/xcode-27-arm64-Readme.md |
Updates NDK reports and paths. |
images/macos/toolsets/toolset-xcode-27.json |
Updates NDK versions. |
images/macos/toolsets/toolset-26.json |
Updates NDK versions. |
images/macos/toolsets/toolset-15.json |
Updates NDK versions. |
images/macos/toolsets/toolset-14.json |
Updates NDK versions. |
images/macos/macos-26-Readme.md |
Updates NDK reports and paths. |
images/macos/macos-26-arm64-Readme.md |
Updates NDK reports and paths. |
images/macos/macos-15-Readme.md |
Updates NDK reports and paths. |
images/macos/macos-15-arm64-Readme.md |
Updates NDK reports and paths. |
images/macos/macos-14-Readme.md |
Updates NDK reports and paths. |
images/macos/macos-14-arm64-Readme.md |
Updates NDK reports and paths. |
Review details
Suppressed comments (4)
images/windows/toolsets/toolset-win-11-arm64.json:93
- This ARM64 image never runs
Install-AndroidSDK.ps1(its Packer template omits that provisioner), and Android is excluded from the ARM64 software report. As a result, neither this NDK block nor the CMake entries above are installed or validated; the image still gets the Visual Studio-bundled NDK R23C (images/windows/Windows11-Arm64-Readme.md:188). Add an ARM64 Android installation path, or scope these entries out, so the claimed default-28/CMake update is actually applied.
"default": "28",
"versions": [
"28", "29", "30"
images/windows/toolsets/toolset-win-11-arm64.json:93
- The same ARM64 test skip also leaves the newly selected NDK default and NDK 30 unverified:
Android.Tests.ps1skips its NDK package cases on ARM64. Add an ARM-safe assertion that the configured NDK majors resolve and are installed, otherwise this toolset can advertise versions the image does not contain.
"default": "28",
"versions": [
"28", "29", "30"
images/windows/toolsets/toolset-win-11-vs2026-arm64.json:93
- This ARM64 image never runs
Install-AndroidSDK.ps1(its Packer template omits that provisioner), and Android is excluded from the ARM64 software report. As a result, neither this NDK block nor the CMake entries above are installed or validated; the image still gets the Visual Studio-bundled NDK R27C (images/windows/Windows11-VS2026-Arm64-Readme.md:188). Add an ARM64 Android installation path, or scope these entries out, so the claimed default-28/CMake update is actually applied.
"default": "28",
"versions": [
"28", "29", "30"
images/windows/toolsets/toolset-win-11-vs2026-arm64.json:93
- The same ARM64 test skip also leaves the newly selected NDK default and NDK 30 unverified:
Android.Tests.ps1skips its NDK package cases on ARM64. Add an ARM-safe assertion that the configured NDK majors resolve and are installed, otherwise this toolset can advertise versions the image does not contain.
"default": "28",
"versions": [
"28", "29", "30"
- Files reviewed: 28/28 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest NDK LTS is 30, so following the NDK versioning policy all images now use 28 as the default, and 29 and 30 available as well.
In the meantime, the Windows on ARM runners now match the standard 2025 runners w.r.t Android CMake versions.
Signed-off-by: crueter crueter@eden-emu.dev