Repository navigation
fix(graph): preserve call bindings when relocating cache hits #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DivyamTalwar
wants to merge
1
commit into
activeloopai:main
Choose a base branch
from
DivyamTalwar:fix/graph-preserve-relocated-cache-bindings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: activeloopai/hivemind
Length of output: 19368
🏁 Script executed:
Repository: activeloopai/hivemind
Length of output: 42114
Validate optional cache fields before returning them.
A relocated cache entry can retain
import_bindingswithspecifier: 42. When a matching raw call reachesresolveOne,resolveModulecalls.startsWithon that number and the build can fail instead of re-extracting the file. Validate both optional arrays and their member fields invalidateItems, then return a cache miss for malformed entries.🐛 Suggested fix
for (const p of ex.parse_errors) { if (p === null || typeof p !== "object") return false; if (typeof p.source_file !== "string") return false; if (typeof p.message !== "string") return false; if (p.location !== undefined && typeof p.location !== "string") return false; } + if (ex.raw_calls !== undefined) { + if (!Array.isArray(ex.raw_calls)) return false; + for (const rc of ex.raw_calls) { + if (rc === null || typeof rc !== "object") return false; + if (typeof rc.caller_id !== "string") return false; + if (typeof rc.callee_name !== "string") return false; + if (rc.receiver !== undefined && typeof rc.receiver !== "string") return false; + } + } + if (ex.import_bindings !== undefined) { + if (!Array.isArray(ex.import_bindings)) return false; + for (const b of ex.import_bindings) { + if (b === null || typeof b !== "object") return false; + if (typeof b.local_name !== "string") return false; + if (typeof b.imported_name !== "string") return false; + if (b.kind !== "named" && b.kind !== "default" && b.kind !== "namespace") return false; + if (typeof b.specifier !== "string") return false; + if (b.type_only !== undefined && typeof b.type_only !== "boolean") return false; + } + } return true; }🤖 Prompt for AI Agents