fix(graph): reject cache hits from a different source dialect - #420
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #419.
Identical source bytes stored under different extensions share a cache key even though language dispatch and TS/TSX grammar selection depend on the extension. A hit can therefore return the wrong language and parse result.
Reject a cached entry when its recorded source extension differs from the requested extension. Preserve same-extension relocation hits. Native extractor controls cover JavaScript/TypeScript and TS/TSX in both directions.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
The repository-native focused tests report 4 failures and 17 passing controls on unchanged production source; the prepared correction passes all 21 focused tests. The final commit is independently validated by the full Node 22/Linux suite with coverage, typecheck, build, duplication guard and critical-only bundle audit. The workflow enforces zero failed and zero skipped tests.
Exact submitted commit:
ce99cd2c54e309a61f4c707dac155003df391a28. Independent Linux job, commands and logs. The checkout is pinned to this commit, not a combined patch branch.The focused tests use isolated files or source fixtures and the real parser/cache/usage code. No customer data, credentials or live model/backend calls are required.
Compatibility and limits
Comparison deliberately remains case-sensitive to match the current TSX grammar dispatch. Compatible extensions may incur conservative cache misses; the on-disk key and format are unchanged. This does not fix lost bindings on relocated cache hits, which is an independent correction.
A clean full macOS suite and native Windows validation are not claimed. Upstream CI approval and maintainer review are separate from this passing independent gate.