fix(graph): preserve Python qualified names without false edges - #422
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #421.
Reducing
requests.SessiontoSessioncan link a class to itself or to an unrelated local class. Separately, treating the leaf of unaliasedimport pkg.utilas a bound name can invent autil.helper()call relationship.Keep plain dotted base names qualified and unresolved instead of guessing a local match. Do not create a leaf namespace binding for an unaliased dotted import; retain module import edges and supported explicit aliases. Native extractor-to-snapshot tests cover both false-edge cases and valid local/aliased controls.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
The repository-native focused tests report 8 failures and 18 passing controls on unchanged production source; the prepared correction passes all 26 focused tests. The final commit is independently validated by the full Node 22/Linux suite with coverage, typecheck, build, duplication guard and critical-only bundle audit. The workflow enforces zero failed and zero skipped tests.
Exact submitted commit:
056df2b02716f8ff9adcbbb816a865a0f5d43b3e. Independent Linux job, commands and logs. The checkout is pinned to this commit, not a combined patch branch.The focused tests use isolated files or source fixtures and the real parser/cache/usage code. No customer data, credentials or live model/backend calls are required.
Compatibility and limits
Qualified-base resolution and general Python evaluation are not implemented. Dynamic base expressions remain unresolved, and unaliased dotted imports do not gain new inferred top-package bindings. PR #270 touches
pushNodefor node deduplication; this fix changes qualification handling rather than duplicating that work.A clean full macOS suite and native Windows validation are not claimed. Upstream CI approval and maintainer review are separate from this passing independent gate.