fix(graph): prefer C definitions over prototype source locations - #434
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #433.
The extractor deduplicates function nodes by ID and keeps the first declaration. When a prototype precedes its definition, the node retains the prototype line rather than the body span, so downstream anchors can miss implementation changes.
Track nodes originating from prototypes and let a subsequent definition replace their source location in place. Retain the same node identity and call relationships, prototype-only nodes, and the first-definition behavior for duplicate conditional definitions.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
14366d1e93d59bab761074e71ac6c7e3967db7a4: independent Node 22/Linux full suite with coverage, 5,856 passed, zero failed, zero skipped. Typecheck, build, duplication guard, critical-only bundle audit and diff checks pass in the same isolated job.Exact checkout, commands and validation logs. Results are for this branch alone, not borrowed from a combined patch branch. Tests use synthetic source/transcripts and temporary files, not customer data, real credentials or live model/backend calls.
Compatibility and limits
This is same-file C extraction only. It does not link headers to definitions in other files, change static/export visibility, or add unsupported pointer-declarator parsing. Existing anchors may change once when their source span moves from prototype to definition.
Current open-PR file inventories and issue titles were checked before submission. A clean full macOS suite and native Windows execution are not claimed. Upstream CI and maintainer acceptance remain separate from the independent validation.