fix(graph): resolve C++ calls in their enclosing namespaces - #436
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #435.
The C++ call pass resolves the caller through a bare-name lookup even when declaration keys are namespace-qualified. Namespaced calls can be omitted or assigned to another same-named function; nested namespace names also lose their outer qualifier.
Track callers by declaration position and compose full namespace keys consistently. Resolve supported unqualified and namespace-qualified callees against enclosing namespaces, preserve explicit global qualification, and conservatively suppress bare-name edges shadowed by parameters, local declarations or structured bindings. Calls in unrepresented nested callable bodies are not attributed to outer functions.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
58c5ba9ea086b041b75e5d899b9f2b59a8bc9bf0: independent Node 22/Linux full suite with coverage, 5,873 passed, zero failed, zero skipped. The same job passes typecheck, production build, duplication guard, critical-only bundle audit and diff checks.Exact checkout, commands, full-suite results and retained logs. Each branch was validated independently. Tests use synthetic code/transcripts and isolated filesystem fixtures, not live model calls or user data.
Compatibility and limits
This remains syntactic intra-file analysis, not a C++ compiler or general overload/type resolver. Overloads still share the pre-existing node identity. Inline class methods, namespace aliases, using-based resolution and full class lookup are not newly supported. The local-name suppression is intentionally conservative across the whole function, so some valid calls may remain unresolved. Nested namespace node IDs change to include their complete namespace path.
The current open-PR file inventory and issue titles were checked before submission. A clean full macOS suite or native Windows execution is not claimed. The independent gate does not replace upstream CI or maintainer review.