fix(graph): retain Rust implementation method identities - #438
Open
DivyamTalwar wants to merge 1 commit into
Open
DivyamTalwar wants to merge 1 commit into
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #437.
The Rust call pass chooses an enclosing function by name rather than its declaration, so same-named methods on different types can share the wrong caller. Owner edges also assume a class-shaped plain impl type, missing generic and enum ownership and collapsing same-named trait methods.
Track each represented callable by source position, preserve complete implementation type spelling in method IDs, and distinguish trait implementations with a type-and-trait-qualified identity. Resolve method ownership to locally declared structs/enums after declaration collection. Preserve constant-generic literal bytes and reject speculative owner links for unsupported scoped/reference types.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
6a9a1942f80f23b17899b8143510e478971b1ba7: independent Node 22/Linux full suite with coverage, 5,864 passed, zero failed, zero skipped. The same job passes typecheck, production build, duplication guard, critical-only bundle audit and diff checks.Exact checkout, commands, full-suite results and retained logs. Each branch was validated independently. Tests use synthetic code/transcripts and isolated filesystem fixtures, not live model calls or user data.
Compatibility and limits
Type aliases, Self, imported/cross-file owners and semantic type equivalence are not resolved. Existing inline-module item IDs remain flattened, so this is not a complete module-identity redesign. Trait method IDs intentionally change to distinguish implementation histories; inherent nongeneric IDs remain unchanged. Calls inside unrepresented closures are left unresolved rather than credited to the outer function. Textual type spelling is preserved, not normalized by a Rust type checker.
The current open-PR file inventory and issue titles were checked before submission. A clean full macOS suite or native Windows execution is not claimed. The independent gate does not replace upstream CI or maintainer review.