fix(skillify): reserve mining slots for supported transcript formats - #440
Open
DivyamTalwar wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: activeloopai/hivemind/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #439.
Local discovery includes Codex rollouts, but nativeJsonlToRows currently parses only Claude-shaped records. The picker can spend its limited budget on unsupported files, then discard them as having no usable pairs without selecting replacements.
Filter unsupported native formats before sampling and compute --n all from the eligible pool. Keep discovery and backfill unchanged. Explicit unsupported --only selections and zero-eligible runs fail with an honest explanation instead of reporting a misleading plan or writing an empty completion marker.
Version Bump
No release requested. Package versions, dependencies, lockfiles and release workflows are unchanged.
Test plan
0d98d0d3d0cb0100f87c910394ad397fd3b92c52: independent Node 22/Linux full suite with coverage, 5,859 passed, zero failed, zero skipped. The same job passes typecheck, production build, duplication guard, critical-only bundle audit and diff checks.Exact checkout, commands, full-suite results and retained logs. Each branch was validated independently. Tests use synthetic code/transcripts and isolated filesystem fixtures, not live model calls or user data.
Compatibility and limits
This does not add Codex transcript parsing or change the sampling quota in #379. With no supported sessions, a later automatic attempt may run again under the existing lock policy because no successful completion marker is written. New integration fixtures isolate home-directory writes with the existing cross-platform fake-home helper; gate/model execution is mocked.
The current open-PR file inventory and issue titles were checked before submission. A clean full macOS suite or native Windows execution is not claimed. The independent gate does not replace upstream CI or maintainer review.