Check each crate against the MSRV it actually advertises - #16
Merged
Conversation
Vendoring the Prime path tracer raised `luacad` to rustc 1.96, but the MSRV job still checked it at 1.89, so every run since has failed at `rustc 1.89.0 is not supported by the following packages`. The 1.95 step for Studio never ran, and it would have failed too: Studio depends on `luacad`, so its advertised 1.95 has also been unbuildable. Only the two -sys crates still hold the workspace MSRV. Check those at 1.89 and the rest of the workspace at 1.96, and correct the `rust-version` of `luacad-studio` and `luacad-wasm`, both of which reach 1.96 through `luacad` whatever features they enable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pTUyDzDKrAf5oufbDQuSV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendoring the Prime path tracer raised
luacadto rustc 1.96, but theMSRV job still checked it at 1.89, so every run since has failed at
rustc 1.89.0 is not supported by the following packages. The 1.95 stepfor Studio never ran, and it would have failed too: Studio depends on
luacad, so its advertised 1.95 has also been unbuildable.Only the two -sys crates still hold the workspace MSRV. Check those at
1.89 and the rest of the workspace at 1.96, and correct the
rust-versionofluacad-studioandluacad-wasm, both of which reach1.96 through
luacadwhatever features they enable.Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_015pTUyDzDKrAf5oufbDQuSV