Repository navigation
Conversation
git's fsmonitor daemon creates a unix socket at <gitdir>/fsmonitor--daemon.ipc. On macOS chokidar uses fs.watch, which cannot watch a socket, so watching the git directory emitted an unhandled error and crashed `aem up`. Ignore the socket and log watcher errors as warnings instead of crashing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aem upcrashes on macOS whencore.fsmonitor=trueis set in the repository. Git's fsmonitor daemon creates a unix socket at<gitdir>/fsmonitor--daemon.ipc.watchGit()watches the whole git directory with chokidar, which usesfs.watchon macOS.fs.watchcannot watch a socket, so chokidar emitted an unhandlederrorevent and the process exited.This change does two things in
watchGit()insrc/up.cmd.js.fsmonitor--daemonpaths in the chokidar options.errorhandler that logs a warning instead of crashing.Related Issues
Fixes #2805