fix(envelope): fail on unparseable adapter output - #987
Merged
aaronjmars merged 2 commits intoAug 30, 2026
Conversation
Resolve glm.sh modify/delete: GLM moved to the Claude gateway in aeonfun#990, so the adapter file stays deleted. Envelope fail-closed is unchanged. Co-Authored-By: Grok <noreply@x.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed adapter output instead of fabricating a successful
0/0envelope.Problem
When an adapter emitted empty, invalid, or otherwise unparseable output,
wrap_raw_outputconverted it into a schema-valid success envelope. The workflow then reported a green run, published the raw blob as the skill result, and recorded zero token usage.This could cause broken runs to be scored, published, or consumed by downstream chain steps as successful work.
Fix
wrap_raw_outputretain diagnostic output on stderr and return exit status 3.run-harnessvalidation and adapter-specific fallback paths.Testing
bash scripts/tests/test_harness_envelope.shbash scripts/tests/test_cursor_adapter.shbash scripts/tests/test_hermes_adapter.shbash scripts/tests/test_harness_adapter_grok.shbash scripts/tests/test_run_harness_sandbox_gate.shbash -non all edited shell scripts